294557 - unexported api calls in pkcs12.h

Status: RESOLVED FIXED

(NSS :: Libraries, defect, P2)

Description

[Jason Reid]

The following api calls in pkcs12.h are not found in a .def file.

SEC_PKCS12PutPFX NOT exported
SEC_PKCS12ValidData NOT exported

Comment 1

[Nelson Bolyard (seldom reads bugmail)]

Is this header file a "public" header file?
If not, this bug is not valid.
If so, we need to decide: are these functions intended to be "public"? 

then if so, we need to add them to the relevant .def file,
and if not, we need to move these declarations to another file, or 
enclose them in an #ifdef with some symbol like PKCS12_private.

Comment 2

[Julien Pierre]

Retargetting all P2s to 3.11.3 .

Comment 3

[Neil Williams]

Attachment: remove super annuated routines

Removes lib/pkcs12/p12creat.c lib/pkcs12/p12dec.c lib/pkcs12/p12exp.c and changes include files. The functions listed by reporter, besides not being exported, are superceded by ones in p21[3d].c.

Comment 4

[Neil Williams]

pkcs12.h is exported so I didn't try to remove it even though it's now 2 lines long.

Comment 5

[Nelson Bolyard (seldom reads bugmail)]

Comment on attachment 272104 [details] [diff] [review]
remove super annuated routines

This patch doesn't show any files being removed.  
The scope of this patch seems to greatly exceed the two functions named in comment 0.  
Maybe the thing to do is to combine the bugs into a single bug, and have one patch that addresses the entire bug.  
As a reviewer, I need to see that the patch addresses the problem in the bug and does not appear to fix issues not describedd in the bug (except trivial things like whitespace or indentation).

Comment 6

[Neil Williams]

Comment on attachment 272104 [details] [diff] [review]
remove super annuated routines

Sorry, this is the wrong patch for this bug.

Comment 7

[Nelson Bolyard (seldom reads bugmail)]

Both functinos are implemented in p12dec.c
They are the only external functions defined in p12dec.c
Deleting them will leave p12dec.c with no external functions.
So, the answer is to cvs remove p12dec.c.

Comment 8

[Neil Williams]

Attachment: remove dead code

This patch retstricts itself to removing the source for these functions. The entire file they reside in is dead code; pkcs12.h is exported or we could remove it also.

Comment 9

[Nelson Bolyard (seldom reads bugmail)]

Comment on attachment 272581 [details] [diff] [review]
remove dead code

r=nelson

Comment 10

[Neil Williams]

Checking in nss/lib/pkcs12/manifest.mn;
/cvsroot/mozilla/security/nss/lib/pkcs12/manifest.mn,v  <--  manifest.mn
new revision: 1.5.2.1; previous revision: 1.5
done
Removing nss/lib/pkcs12/p12dec.c;
/cvsroot/mozilla/security/nss/lib/pkcs12/p12dec.c,v  <--  p12dec.c
new revision: delete; previous revision: 1.5
done
Checking in nss/lib/pkcs12/pkcs12.h;
/cvsroot/mozilla/security/nss/lib/pkcs12/pkcs12.h,v  <--  pkcs12.h
new revision: 1.3.28.1; previous revision: 1.3
done