Closed Bug 294609 Opened 19 years ago Closed 19 years ago

Restore Ctrl+Enter to highlight for the Find Bar

Categories

(Toolkit :: Find Toolbar, defect, P2)

defect

Tracking

()

RESOLVED FIXED
mozilla1.8final

People

(Reporter: bugzilla, Assigned: Gavin)

Details

Attachments

(1 file)

It was removed as part of bug 280159.
*-Enter is pretty overloaded as a keystroke combo and very focus-sensitive. 
Backwards-compat logic says we should restore it, but I think it was a bad
choice in the first place, and if we're going to be forever bound by past
choices we're going to hit a wall real fast.

There's also bug 259454 about IME input and FAYT that was going to send
Ctrl-Enter events to click focused links from the find toolbar, and since you
need the toolbar to do IME input there's no easy way to use the traditional
"find links" and hit Enter in the original typeaheadfind.  If I find a link
using Ctrl-F, I have to jump through hoops to invoke it from the keyboard.  The
gain there definitely outweighs the loss of a duplicate shortcut, and makes
FT/FAYT closer in terms of keystrokes required.  If the Find Toolbar is supposed
to be a method of invoking a FAYT-like experience, having conflicting shortcuts
isn't acceptable.
*-Enter isn't overloaded in the find bar at all. It's currently used for nothing
else. People open the find bar and the find textbox has focus.

The number one priority of the find bar is to provide a good find experience for
the millions of people out there who have no idea what "FAYT" is and never used
the pre-1.0 implementation of it. The number two priority is to support as much
of the old implementation as possible.
Status: NEW → ASSIGNED
Furthermore, I don't see how the other justification--that IME users can't
follow links quickly because they have to use the toolbar--could possibly be a
reason to remove this keybinding. We have to assume that even the huge majority
of English users can't follow links quickly, because we don't advertise the '
method of searching anywhere. So if that's important functionality, that's a new
bug that requires a new UI discussion. But we shouldn't remove an *advertised*
keybinding and redirect it to do something else entirely, all because an
*unadvertised* keybinding doesn't work properly for a subset of our users.

(Besides, why don't we just use Shift+Enter for all users to follow links)
Target Milestone: --- → Firefox1.1
Ok, so you're going to remove the Find Previous modifier-Enter binding instead
of the Highlight binding?  How is that better?

And the keybinding is only advertised in the tooltip, which a non-mouse user
will never see, which is kind of a rough "advertisement" to cite.

I think before we push the panic button on this, lets see what feedback we get
from the alpha, and in the meantime figure out a more cohesive solution that a)
lets people use Find to navigate, which was the big win for FAYT, and b) doesn't
force users to relearn things completely if they enable FAYT in prefs..  There's
also the argument that highlight should be a permanent toggle, although until we
don't horribly break www.mozilla.org's sidebars with highlight, maybe that's not
a good idea.
Target Milestone: Firefox1.1 → ---
Target Milestone: --- → Firefox1.1
Whoops, forgot about Find Previous.

Yes, the keybinding is advertised in a tooltip. But that's much more visible
than the "find links" keybinding, which isn't advertised anywhere.

Highlight used to be a permanent toggle but it was disabled for the reason you
outline.

Sorry, I don't mean to push the panic button, but I do think this was a mistake.
And I don't think any feedback from the alpha is going to help us one way or
another...so I would like to fix this now.
The keybinding is also advertised in a number of Firefox books, which is another
reason we shouldn't be removing things without a great reason.

I just don't see anything here that passes the "Your favorite shortcut was
removed because _________" test.
One more thing: I don't see how making Ctrl+Enter follow links supports your
point (2), being consistent between the find bar and find as you type. If I, a
non-IME user, enable FAYT in prefs and I type a link, I hit Enter to follow it.
And I expect Ctrl+Enter to open it in a new tab.
Gah, true about Ctrl-Enter, forest for the trees in my brain.  I still wish
Ctrl-F let me do the link focusing thing right, but that's future tweaking.

Let's just leave it at "I hate this whole mess" and be done with it, and we can
restore the keybinding since it is in all of the books, and leave the conflict
to be resolved in the customizable keybinding future (I think at that point
we'll be whacking a LOT of things, like the cross-platform mess, etc).
Assignee: firefox → gavin.sharp
Attachment #186448 - Flags: review?(mconnor)
OS: Windows XP → All
Priority: -- → P2
Hardware: PC → All
Version: unspecified → Trunk
Attachment #186448 - Flags: review?(mconnor) → review+
Attachment #186448 - Flags: approval-aviary1.1a2?
Whiteboard: [patch-r+]
Attachment #186448 - Flags: approval-aviary1.1a2? → approval-aviary1.1a2+
Whiteboard: [patch-r+] → [patch-r+][checkin needed][a+]
checked in
Whiteboard: [patch-r+][checkin needed][a+] → [patch-r+][a+]
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Whiteboard: [patch-r+][a+]
Product: Firefox → Toolkit
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: