294763 - Provide size threshold for Display Inline Attachments

Status: NEW

(MailNews Core :: Attachments, enhancement)

Description

[Nils Durner]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; de-DE; rv:1.7.8) Gecko/20050511 Firefox/1.0.4
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; de-DE; rv:1.7.8) Gecko/20050511 Firefox/1.0.4

Attachments are often displayed as part of the mail. This is painful if it is a
large binary file which cannot be displayed by TB anyway. Opening a mail with a
20 MB attachment takes a while to open.

Reproducible: Always

Steps to Reproduce:
1. Create a file with the content "Hello" and rename it to test.dmp
2. Send test.dmp as attachment


Actual Results:  
The mail I received contained "Hello" at the end of the message.

Expected Results:  
TB should check the file type (extension, actual content) and/or the size of the
attachment before it gets displayed. Binary attachments or attachments greater
than a few KB (500?) should not be displayed inline.

Comment 1

[Nils Durner]

Attachment: Testcase

Comment 2

[David :Bienvenu]

View | display attachments inline is a toggle that lets you choose not to
display attachments inline...

Comment 3

[Nils Durner]

Well, this is just a workaround and not a solution.
It's okay if images, raw text etc. are displayed inline if they aren't
 1) too big
 2) not really displayable

Inlining is a great feature in general, so I don't want to turn it off entirely
just because I receive some big attachment every now and then.

Comment 4

[Mike Cowperthwaite]

This is a reasonable idea, particularly for IMAP over dialup.  I assume this is 
primarily a problem for images, as the other types that are displayed inline 
(text, HTML and forwarded messages) tend to be much much smaller.  Note that 
this feature would not apply to HTML mail that (e.g.) includes an <img> tag 
referencing a 20MB image.

I would say, however, that better support for suppressing inline display for
Content-Disposition:attachment (bug 147461) should be a higher priority.  Then 
people who receive a message with a 20MB JPEG marked 'inline' can complain to 
the person who sent them the message, rather than to Mozilla.  :)

Comment 5

[Charles]

I second this...

Now that bug 345832 is being worked on, this one dovetails in quite nicely with that solution.

We really need the ability to allow small graphics, such as those used for email signatures and the like, to be viewed inline, but not large ones.

A sensible default (100K?), and an about:config pref that can be defined to over-ride it would be acceptable to me.