Closed Bug 294854 Opened 15 years ago Closed 9 years ago

nsIsIndexFrame::OnSubmit is just brainless

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set

Tracking

()

RESOLVED FIXED

People

(Reporter: sicking, Unassigned)

References

Details

(Keywords: helpwanted, Whiteboard: [good first bug])

Attachments

(1 file)

The uri handling code in nsIsIndexFrame::OnSubmit is way too obfuscated. I'll
clean this up when I get some time.
Keywords: helpwanted
Whiteboard: [good first bug]
Depends on: 326369
Attached patch Proposed patchSplinter Review
Patch which cleans up nsIsIndexFrame::OnSubmit.  I removed some unused variables and moved some code closer to where it is actually used.

Looking through the code, it seems to be straight forward and understandable with the comments that are now in the file.  Is this the type of cleanup you were thinking of and is there any other cleanup needed?
So, does the patch resolve the problem?
Assignee: form-submission → nobody
QA Contact: ian → form-submission
Comment on attachment 272418 [details] [diff] [review]
Proposed patch

Ugh, sorry about the lack of review here. And unfortunately (or rather, fortunately) all of this code is going away with the HTML5 parser. So I'd rather not muck with it for now.
Jonas, since the HTML5 parser arrived, can this bug be closed?  No point in cluttering up the [good first bug] list with bugs that aren't even valid.
Yes, I think that is the right cause of action.
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Component: HTML: Form Submission → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.