294854 - nsIsIndexFrame::OnSubmit is just brainless

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

The uri handling code in nsIsIndexFrame::OnSubmit is way too obfuscated. I'll
clean this up when I get some time.

Comment 1

[Adam Becevello]

Attachment: Proposed patch

Patch which cleans up nsIsIndexFrame::OnSubmit.  I removed some unused variables and moved some code closer to where it is actually used.

Looking through the code, it seems to be straight forward and understandable with the comments that are now in the file.  Is this the type of cleanup you were thinking of and is there any other cleanup needed?

Comment 2

[Shriram (irc: Mavericks)]

So, does the patch resolve the problem?

Comment 3

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Comment on attachment 272418 [details] [diff] [review]
Proposed patch

Ugh, sorry about the lack of review here. And unfortunately (or rather, fortunately) all of this code is going away with the HTML5 parser. So I'd rather not muck with it for now.

Comment 4

[Josh Matthews [:jdm]]

Jonas, since the HTML5 parser arrived, can this bug be closed?  No point in cluttering up the [good first bug] list with bugs that aren't even valid.

Comment 5

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Yes, I think that is the right cause of action.