295178 - Misleading l10n note in customizeCharset.dtd

Status: RESOLVED FIXED

(Toolkit :: Preferences, defect)

Description

[Ognyan Kulev]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; bg; rv:1.8b2) Gecko/20050523 Firefox/1.0+
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; bg; rv:1.8b2) Gecko/20050523 Firefox/1.0+

mozilla/toolkit/locales/en-US/chrome/global/customizeCharset.dtd has the
following content:

<!-- LOCALIZATION NOTE  Character Encoding Preferences Dialog: Do NOT localize
the term "Character Encoding" -->

<!ENTITY title.label      "Customize Character Encoding">
<!ENTITY left.header      "Character Encoding">
<!ENTITY current.label    "Active Character Encodings:">
<!ENTITY remove.label     "Remove">
<!ENTITY additional.label "Available Character Encodings:">
<!ENTITY add.label        "Add">

I think that the l10n note should be removed -- I can't see why "Character
Encoding(s)" should not be translated.

Reproducible: Always

Steps to Reproduce:

Comment 1

[Ognyan Kulev]

Actually, &left.header; is not used in the dialog.  Perhaps this is what should
not be translated?  If so, the l10n not should be for this entity explicitly but
not for the whole file.

I can't change version in Bugzilla, but it's about CVS Firefox.

Comment 2

[Simon Montagu :smontagu]

I don't know the reason for this note, and couldn't find one through code
archaeology.

Comment 3

[Nickolay_Ponomarev]

Attachment: remove the unused entity along with the misleading localization note

The left.header entity is a leftover from seamonkey's prefs window, and the strange localization note seems to have been there from the first revision.

Comment 4

[:Gavin Sharp [email: [e-mail]]]

mozilla/toolkit/content/customizeCharset.xul 	1.4.2.1
mozilla/toolkit/locales/en-US/chrome/global/customizeCharset.dtd 	1.4.2.1

mozilla/toolkit/locales/en-US/chrome/global/customizeCharset.dtd 	1.5
mozilla/toolkit/content/customizeCharset.xul 	1.5