295407 - Finish button doesn't dismiss PFS dialog (manual installs)

Status: RESOLVED FIXED

(Toolkit Graveyard :: Plugin Finder Service, defect)

Description

[sairuh (rarely reading bugmail)]

found using 2005052410-trunk (deer park) on linux fc3. Tracy has also seen this
occur on Mac OS X.

1. make sure you don't have all the possible plugins installed for your machine
--specifically those requiring a "manual" type of installation. in my case, I
didn't have Java or Acrobat installed.

2. go to this plugin finder test:

http://weblogs.mozillazine.org/marcia/archives/plugin-test.html

3. click on the "Install Missing Plugins" button in the notification bar above
the page content.

4. go through the panel of the Plugin Finder Service (PFS) dialog, until you
reach the last panel titled "Completing the Plugin Finder Service," which
contains the Finish button.

5. don't manually install the plugins, instead click the Finish button.

results: even those it appears active, clicking Finish doesn't dismiss the PFS
dialog. no js errors appear in the js console. interestingly, hitting the Esc
key does dismiss the dialog.

note: this is doesn't appear to be a problem when I click a puzzle-piece for
plugin content (such as Director on Linux, ie, the 2nd piece in the sample URL
above, or Quicktime on Linux) for which there's no compatible plugin. in such
cases, the Finish button does dismiss the dialog. odd.

Comment 1

[:Gavin Sharp [email: [e-mail]]]

*** Bug 295010 has been marked as a duplicate of this bug. ***

Comment 2

[:Gavin Sharp [email: [e-mail]]]

See also bug 259491, bug 276528.

Comment 3

[Doron Rosenberg (IBM)]

I can reproduce on linux for acrobat as well.

Comment 4

[Doron Rosenberg (IBM)]

###!!! ASSERTION: bogus trigger: '!mItem->mURL.IsEmpty()', file
/home/doron/mozbuilds/firefox-trunk/mozilla/xpinstall/src/nsXPInstallManager.cpp,
line 603
Break: at file
/home/doron/mozbuilds/firefox-trunk/mozilla/xpinstall/src/nsXPInstallManager.cpp,
line 603

Is what I get in the failure cases.  Investigating what broke.

Comment 5

[Doron Rosenberg (IBM)]

Attachment: patch

Don't ask me why this works, it just does.

Comment 6

[Doron Rosenberg (IBM)]

checked in.