295460 - Should (content instanceof ChromeWindow) not be true?

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[[e-mail]]

I queried Bugzilla for instanceof ChromeWindow and found no hits, which
surprised me, as Mozilla 1.6 has this bug. Steps to reproduce problem:
1. From the browser, open the JS console
2. Evaluate top.opener.content instanceof ChromeWindow

Expected result: false

Actual result: true

Workaround: use Components.interfaces.nsIDOMChromeWindow

Comment 1

[Martijn Wargers (dead)]

It returns true for me now, with the 2005-08-27 trunk build. -> WFM?

Comment 2

[[e-mail]]

(In reply to comment #1)
>It returns true for me now, with the 2005-08-27 trunk build. -> WFM?
Comment #0 says Expected result: false

Comment 3

[Boris Zbarsky [:bzbarsky]]

This happens because sClassInfoData[class_name_struct->mDOMClassInfoID].mProtoChainInterface is nsIDOMWindow for chromewindow.

And that happens because the classinfo for ChromeWindow is:

  DOM_CLASSINFO_MAP_BEGIN_NO_CLASS_IF(ChromeWindow, nsIDOMWindow)

which means to use nsIDOMWindow as the proto chain interface.  Should we be using nsIDOMChromeWindow instead?  I'm not sure what else that proto chain interface affects...

Comment 4

[Peter Van der Beken [:peterv]]

Looks like this is fixed now. |alert(top.opener.content instanceof ChromeWindow)| alerts true for me. No idea what whould have fixed it.

Comment 5

[Dão Gottwald [:dao]]

(In reply to comment #4)
> Looks like this is fixed now. |alert(top.opener.content instanceof
> ChromeWindow)| alerts true for me.

It's expected to be false.

Comment 6

[Peter Van der Beken [:peterv]]

Attachment: v1

Sorry, got confused.

This works I think, need to think a bit more about it. Also need to add an automated testcase.

Comment 7

[Dão Gottwald [:dao]]

(In reply to comment #6)
> Created attachment 418021 [details] [diff] [review]
> v1
> 
> Sorry, got confused.
> 
> This works I think, need to think a bit more about it.

Have you thought about it? Any update?

Comment 8

[Peter Van der Beken [:peterv]]

ChromeWindow was removed by switching to WebIDL, there's an isChromeWindow method on Window (added in bug 1383059).