295597 - full screen mode on http://www.bbc.co.uk/radio/aod/mainframe.shtml?http://www.bbc.co.uk/radio/aod/radio1.shtml?onair goes odd when 'view compact size' link is clicked

Status: RESOLVED INCOMPLETE

(Core :: DOM: Core & HTML, defect, P5)

Description

[Max]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050513 Firefox/1.0+
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050513 Firefox/1.0+

If you view
http://www.bbc.co.uk/radio/aod/mainframe.shtml?http://www.bbc.co.uk/radio/aod/radio1.shtml?onair
in full screen mode, then click on the 'View Compact Size' link, the window goes
very odd.

Reproducible: Always

Steps to Reproduce:
1. Go to
http://www.bbc.co.uk/radio/aod/mainframe.shtml?http://www.bbc.co.uk/radio/aod/radio1.shtml?onair
2. Go into full screen mode (F11)
3. Click on 'View Compact Size' link

Actual Results:  
Window goes odd, items overlap etc.

Expected Results:  
It should not behave in such an odd way.

Comment 1

[Martijn Wargers (dead)]

What do you mean with window goes odd, items overlap?
You mean that when you click the 'View Compact Size' link, suddenly a horizontal
scrollbar appears? That would be bug 261897.

Comment 2

[Max]

Attachment: Screenshot of odd fullscreen behaviour

Here is a screenshot of the problem.

Comment 3

[Max]

I've just realised the attachment isn't very clear. Note that there is another
firefox window behind it.

Comment 4

[Max]

Attachment: Screenshot of odd fullscreen behaviour (clearer screenshot)

Here is a clearer screenshot than the other one.

Comment 5

[Martijn Wargers (dead)]

So you mean, when in fullscreen mode, scripts should not be allowed to tamper
with the window size?

Comment 6

[Max]

I have no idea, but technically if the window size is modified in full screen
mode, then it's no longer full screen, so perhaps it shouldn't stay in full
screen mode.

Comment 7

[Martijn Wargers (dead)]

Well, if the user has pressed F11 (for full screen), he probably wants it to
remain full screen. so I think it would make more sense if scripts are not
allowed to change window dimensions, move windows when in full screen mode.
That seems to be what IE6 is doing.

Comment 8

[Max]

I think the choice is either to: disable scripts that modify the window size
whilst in full screen mode
or: when one of these scripts is activated, to get out of full screen mode, so
that the window can be displayed correctly.

Comment 9

[Martijn Wargers (dead)]

Attachment: patch

Well, I like the first choice more ;-)
I think this should work, but it seems not to have any effect (which I find
odd).

Comment 10

[Boris Zbarsky [:bzbarsky]]

martijn, that does look like it should work... where did you build after
applying that diff?

Comment 11

[Martijn Wargers (dead)]

I rebuilt everything, and I tried the patch multiple times, so i'm quite sure
the patch doesn't work for some reason. If anyone wants to try it, please do.

Comment 12

[Boris Zbarsky [:bzbarsky]]

Hmm..  You know what?  I bet the window that's in fullscreen mode is the chrome
window and the checks are being done on the content window...

Comment 13

[[e-mail]]

SetFullScreen fowards to the top-level chrome window, but GetFullScreen does not
(and don't ask me how inner/outer windows affect this...)

Comment 14

[u597032]

Page no longer active