Closed Bug 295656 Opened 19 years ago Closed 19 years ago

[FIXr]Viewmanagers for pages with subframes leak

Categories

(Core :: Web Painting, defect, P1)

x86
Linux
defect

Tracking

()

RESOLVED FIXED
mozilla1.8beta3

People

(Reporter: bzbarsky, Assigned: bzbarsky)

References

Details

(Keywords: memory-leak)

Attachments

(1 file)

This is fallout from the patch for bug 274784.  nsViewManager::SetRootView ends
up addrefing the root twice, so we leak the viewmanager for any page with subframes.
Summary: Viewmanagers for subframes leak → Viewmanagers for pages with subframes leak
Attached patch PatchSplinter Review
Attachment #184649 - Flags: superreview?(rocallahan)
Attachment #184649 - Flags: review?(rocallahan)
Keywords: mlk
Priority: -- → P1
Summary: Viewmanagers for pages with subframes leak → [FIX]Viewmanagers for pages with subframes leak
Target Milestone: --- → mozilla1.8beta3
Attachment #184649 - Flags: superreview?(rocallahan)
Attachment #184649 - Flags: superreview+
Attachment #184649 - Flags: review?(rocallahan)
Attachment #184649 - Flags: review+
Comment on attachment 184649 [details] [diff] [review]
Patch

Requesting 1.8b3 approval for this leak fix.
Attachment #184649 - Flags: approval1.8b3?
Summary: [FIX]Viewmanagers for pages with subframes leak → [FIXr]Viewmanagers for pages with subframes leak
Attachment #184649 - Flags: approval1.8b3? → approval1.8b3+
Fixed for 1.8b3.
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Component: Layout: View Rendering → Layout: Web Painting
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: