29601 - File.delete fails and returns -229 error.

Status: VERIFIED FIXED

(Core Graveyard :: Installer: XPInstall Engine, defect, P3)

Description

[David Epstein]

builds 2000-02-28. all platforms.
1. Go to http://jimbob/trigger2.html.
2. Select a_fileop_filedelete from dropdown, or enter in URL field 
http://jimbob/jars/a_fileop_filedelete.xpi.
3. Trigger. OK.
4. Check logfile.
Results: Install failed with -229 error.
5. Check Program folder for filedelete.txt.
Result: Not there.
Expected. File should first be installed (first part of script), then deleted.
note: If we comment out the file install part, manually copy the .txt into 
the Program directory, and just trigger the file delete part, it still 
doesn't work. 
fileDelete (install object) works. It's the File.delete that isn't. See script 
at http://jimbob/cracked/a_fileop_filedelete/install.js

Comment 1

[David Epstein]

changed QA contact to [e-mail]

Comment 2

[Cathleen]

This is a JAR test bug.

Test case is trying to install a file called "filedelete.txt", but inside the 
test JAR file, it does not contain a file called "filedelete.txt", but a file 
called "smrtupdt.txt" exist. 

So, getting a -229 (script error) is indeed a correct error msg.

Comment 3

[David Epstein]

Sorry about that. I rezipped this up with filedelete.txt. It's failing w/ -229:
-------------------------------------------------------------------------------
file:///C|/FileOps/a_fileop_filedelete/a_fileop_filedelete.xpi  --  02/29/2000 
11:31:35
-------------------------------------------------------------------------------


     Install **FAILED** with error -229
     Finished Installation  02/29/2000 11:31:35

Comment 4

[Cathleen]

sounds like a FileSpec problem with file paths....

Comment 5

[David Epstein]

I tried the same thing I did for the File.copy case (bug 29602):
fTemp = f + "/" + jarSrc;  // instead of f + jarSrc;
fileSource = getFolder("file:///", fTemp);

This did not change anything. still get -229 cross platform.

Comment 6

[Cathleen]

David, it's failing because we're unable to get to the script inside of the xpi 
file.  Looks like the xpi file maybe corrupted.  I even downloaded the file 
by itseld, and I was not able to open it in WinZip.
Can you check?

Comment 7

[David Epstein]

Jimmy and I did some follow-up work on this and found that File.Delete 
(capitalized) will install the file, but not delete it and returning -229 
(Jimmy created a_fileop_filedelete2.xpi on http://jimbob/jars). Where as 
File.delete completely fails and returns -229. fileDelete (the old method in the 
install object) doesn't return the error, but has the problem with the forward 
slash (as with other FileOp routines like copy and execute). 

Here's the logfile for a_fileop_filedelete2.xpi (using File.Delete):

-------------------------------------------------------------------------------
http://jimbob/jars/a_fileop_filedelete2.xpi  --  03/03/2000 15:26:25
-------------------------------------------------------------------------------

     Acceptance: a_fileop_filedelete
     -------------------------------

     ** addFile returns = 0
     [1/1]	Installing: C:\Program Files\Netscape\Netscape 
6\bin\filedelete.txt

     Install completed successfully
     The File Delete part
     --------------------

     ** The file pathway = C:\Program Files\Netscape\Netscape 
6\bin\filedelete.txt

     Install **FAILED** with error -229

     Install **FAILED** with error -229
     Finished Installation  03/03/2000 15:26:25

Comment 8

[David Epstein]

To make this clearer, I created a_fileop_filedelete3.xpi (does not install the 
file, it just is written to delete an existing file using File.delete). Trigger 
this from http://jimbob/jars/a_fileop_filedelete3.xpi. Before triggering, place 
filedelete.txt in the "Program" directory. A copy of filedelete.txt is zipped up 
in the archive... After triggering, the file is not deleted from the directory.

Comment 9

[Cathleen]

dbragg will investigate
bug meeting 3/20

Comment 10

[Cathleen]

moving to M16

Comment 11

[Doug Turner (:dougt)]

Marking as fixed:

-------------------------------------------------------------------------------
http://jimbob/jars/a_fileop_filedelete2.xpi  --  04/23/2000 21:28:04
-------------------------------------------------------------------------------
 
     The File Delete part
     --------------------
 
     ** The file pathway = /builds/dougt/mozilla/dist/bin/filedelete.txt
     ** fileDelete returns = 0
     [1/1]      Delete File: /builds/dougt/mozilla/dist/bin/filedelete.txt
 
     Install completed successfully
     Finished Installation  04/23/2000 21:28:04

-------------------------------------------------------------------------------
http://jimbob/jars/a_fileop_filedelete.xpi  --  04/23/2000 21:23:29
-------------------------------------------------------------------------------
 
     Acceptance: a_fileop_filedelete
     -------------------------------
 
     ** addFile returns = 0
     [1/1]      Installing: /builds/dougt/mozilla/dist/bin/filedelete.txt
 
     Install completed successfully
     The File Delete part
     --------------------
 
     ** The file pathway = /builds/dougt/mozilla/dist/bin/filedelete.txt
     ** fileDelete returns = 0
     [1/1]      Delete File: /builds/dougt/mozilla/dist/bin/filedelete.txt
 
     Install completed successfully
     Finished Installation  04/23/2000 21:23:29

Verified on linux.

Comment 12

[David Epstein]

works fine. tested on WinNT, Win98, Linux and Mac.