Closed
Bug 296014
Opened 20 years ago
Closed 20 years ago
[FIXr]Memory leak in nsDOMUIEvent::GetClientPoint
Categories
(Core :: DOM: Events, defect, P1)
Tracking
()
RESOLVED
FIXED
mozilla1.8beta3
People
(Reporter: bzbarsky, Assigned: bzbarsky)
Details
(Keywords: memory-leak)
Attachments
(1 file)
|
1.04 KB,
patch
|
roc
:
review+
roc
:
superreview+
shaver
:
approval1.8b3+
|
Details | Diff | Splinter Review |
We're assigning a raw addrefed ptr into an nsCOMPtr...
|
Assignee | |
Comment 1•20 years ago
|
||
docWidget is an nsCOMPtr and GetParent() returns a raw addrefed pointer...
Attachment #184897 -
Flags: superreview?(rocallahan)
Attachment #184897 -
Flags: review?(rocallahan)
|
|
Assignee | |
Updated•20 years ago
|
Keywords: mlk
Priority: -- → P1
Summary: Memory leak in nsDOMUIEvent::GetClientPoint → [FIX]Memory leak in nsDOMUIEvent::GetClientPoint
Target Milestone: --- → mozilla1.8beta3
file a bug about converting nsIWidget::GetParent to return already_AddRefed?
Attachment #184897 -
Flags: superreview?(roc)
Attachment #184897 -
Flags: superreview+
Attachment #184897 -
Flags: review?(roc)
Attachment #184897 -
Flags: review+
|
|
Assignee | |
Comment 3•20 years ago
|
||
That's bug 227489.
The problem is that it requires either manual inspection of all GetParent calls
(and we have lots of those for frames and content nodes that would need to be
filtered out) or changing the method name, test-compiling on all platforms to
catch all users and fix them up as needed, then changing it back....
|
|
Assignee | |
Comment 4•20 years ago
|
||
Comment on attachment 184897 [details] [diff] [review]
Fix
Requesting 1.8b3 approval for simple leak fix.
Attachment #184897 -
Flags: approval1.8b3?
|
|
Assignee | |
Updated•20 years ago
|
Summary: [FIX]Memory leak in nsDOMUIEvent::GetClientPoint → [FIXr]Memory leak in nsDOMUIEvent::GetClientPoint
|
||
Comment 5•20 years ago
|
||
Comment on attachment 184897 [details] [diff] [review]
Fix
a=shaver
Attachment #184897 -
Flags: approval1.8b3? → approval1.8b3+
|
|
Assignee | |
Comment 6•20 years ago
|
||
Fixed for 1.8b3.
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•