Closed Bug 296019 Opened 20 years ago Closed 20 years ago

[FIXr]leak in history autocomplete

Categories

(Firefox :: Bookmarks & History, defect, P3)

defect

Tracking

()

RESOLVED FIXED
Firefox1.5

People

(Reporter: bzbarsky, Assigned: bzbarsky)

Details

(Keywords: memory-leak)

Attachments

(1 file)

Someone apparently couldn't decide whether some out params should be addrefed or
not, so they had nsGlobalHistory::AutoCompleteSearch sometimes do it and
sometimes not and callers never release.  But that leaks....
Attached patch FixSplinter Review
Attachment #184901 - Flags: review?(mconnor)
OS: Linux → All
Priority: -- → P3
Hardware: PC → All
Target Milestone: --- → Firefox1.1
Comment on attachment 184901 [details] [diff] [review]
Fix

oy.
Attachment #184901 - Flags: review?(mconnor) → review+
OS: All → Linux
Priority: P3 → --
Hardware: All → PC
Target Milestone: Firefox1.1 → ---
Target Milestone: --- → Firefox1.1
Argh, sorry about that.
OS: Linux → All
Priority: -- → P3
Hardware: PC → All
Comment on attachment 184901 [details] [diff] [review]
Fix

Requesting 1.1a2 approval for simple leak fix.
Attachment #184901 - Flags: approval-aviary1.1a2?
Summary: [FIX]leak in history autocomplete → [FIXr]leak in history autocomplete
Comment on attachment 184901 [details] [diff] [review]
Fix

a=shaver
Attachment #184901 - Flags: approval-aviary1.1a2? → approval-aviary1.1a2+
Fixed for 1.1a2.
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
Component: History → Bookmarks & History
QA Contact: history → bookmarks
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: