296271 - Next should not submit the report immediately

Status: RESOLVED FIXED

(Other Applications Graveyard :: Reporter, defect)

Description

[Mike Kaply [:mkaply]]

I wanted to look at the new reporter feature so I put in some info and clicked
Next. It got submitted.

this is not what I expected.

If that is the case, it should not be Next, it should be submit. Next implies
there is another step.

Comment 1

[Robert Accettura [:raccettura]]

Attachment: Patch v1

Comment 2

[Robert Accettura [:raccettura]]

Comment on attachment 185074 [details] [diff] [review]
Patch v1

Not sure if we need to do something about spacing as the button looks somewhat
crowded looking at it in XP.  At least on my system.

Comment 3

[Mike Connor [:mconnor]]

Comment on attachment 185074 [details] [diff] [review]
Patch v1

"Submit" should be sufficient in this case. 

Submit is a well-known convention for forms, so rather than bork the spacing,
just use that.

Comment 4

[Robert Accettura [:raccettura]]

Fix checked in

Comment 5

[Marek Stępień [:marcoos, inactive]]

+  reportWizard.getButton('next').label = strbundle.getString("submitReport") + ">";

Is this ">" really needed? It looks weird. ;-)

Comment 6

[Wojciech Kapusta]

> Is this ">" really needed? It looks weird. ;-)

I think, it is worse: It looks like a bug of the translators.

Comment 7

[Robert Accettura [:raccettura]]

Attachment: Remove '>'

Agreed, lets remove it

Comment 8

[Robert Accettura [:raccettura]]

Attachment: Remove '>' (with ; this time)

Deleted 1 char to many.

Comment 9

[Robert Accettura [:raccettura]]

We should get this into Firefox 2.0.  No real risk, and doesn't effect localization since it was hardcoded.

Comment 10

[Mike Schroepfer]

Comment on attachment 237868 [details] [diff] [review]
Remove '>' (with ; this time)

a=schrep

Comment 11

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Not a blocker, but you can still check the patch in if you get it in soon.

Comment 12

[Robert Accettura [:raccettura]]

Landed on branch and trunk