29638 - compile-time error in nsWebShell.cpp on AIX-4.3.2

Status: CLOSED FIXED

Description

[Ciaran Deignan]

When compiling nsWebShell.cpp on AIX-4.3.2 with the IBM C compiler v3.6.6
the following error is displayed

"nsWebShell.cpp", line 110.22: 1540-092: (S) "static" conflicts with previous 
"extern" declaration.

This was working yesterday (monday 28/2).

The line in question appears to have been introduced as the solution to bug 
28171.

Comment 1

[Jim Dunn]

I just sent Frank a note on this.  My proposed fix (which I am
testing) is to remove NS_DECLARE_ID from nsIPlatformCharset.h
which is in intl/uconv/public.

Comment 2

[Ciaran Deignan]

With the proposed modifcation (I put the lines 41 and 42 of nsIPlatformCharset.h 
in comments) I get an undefined identifier in intl/uconv/src/nsUConvModule.cpp:

"nsUConvModule.cpp", line 128.26: 1540-013: (S) Identifier "kPlatformCharsetCID" 
is undefined.
"nsUConvModule.cpp", line 167.38: 1540-013: (S) Identifier "kPlatformCharsetCID" 
is undefined.
make[4]: *** [nsUConvModule.o] Error 1
make[4]: Leaving directory `/internet/port/mozilla/intl/uconv/src'

Comment 3

[Jim Dunn]

Created attachment 5900 [details] [diff] [review]
Diff of changes

Comment 4

[Jim Dunn]

updating depencencies

Comment 5

[Jim Dunn]

reassigning, i have a fix

Comment 6

[Frank Tang]

how about 
/rdf/datasource/src/nsFileSystemDataSource.cpp, line 270 -- 
NS_WITH_SERVICE(nsIPlatformCharset, platformCharset, kPlatformCharsetCID, &rv);
?

I get this from 
http://lxr.mozilla.org/seamonkey/search?string=kPlatformCharsetCID

It seems all other files have static, but not this one.

Comment 7

[Jim Dunn]

Frank this code is commented out.
Should I add the NS_DECLARE_CID(kPlatformCharset) and put it in a  comment?

Comment 8

[Jim Dunn]

closing