Closed Bug 29638 Opened 25 years ago Closed 25 years ago

compile-time error in nsWebShell.cpp on AIX-4.3.2

Categories

(SeaMonkey :: Build Config, defect, P3)

Other
AIX

Tracking

(Not tracked)

CLOSED FIXED

People

(Reporter: ciaran.deignan, Assigned: jdunn)

References

()

Details

Attachments

(1 file)

When compiling nsWebShell.cpp on AIX-4.3.2 with the IBM C compiler v3.6.6 the following error is displayed "nsWebShell.cpp", line 110.22: 1540-092: (S) "static" conflicts with previous "extern" declaration. This was working yesterday (monday 28/2). The line in question appears to have been introduced as the solution to bug 28171.
Assignee: jdunn → ftang
I just sent Frank a note on this. My proposed fix (which I am testing) is to remove NS_DECLARE_ID from nsIPlatformCharset.h which is in intl/uconv/public.
With the proposed modifcation (I put the lines 41 and 42 of nsIPlatformCharset.h in comments) I get an undefined identifier in intl/uconv/src/nsUConvModule.cpp: "nsUConvModule.cpp", line 128.26: 1540-013: (S) Identifier "kPlatformCharsetCID" is undefined. "nsUConvModule.cpp", line 167.38: 1540-013: (S) Identifier "kPlatformCharsetCID" is undefined. make[4]: *** [nsUConvModule.o] Error 1 make[4]: Leaving directory `/internet/port/mozilla/intl/uconv/src'
Attached patch Diff of changesSplinter Review
updating depencencies
Blocks: 18687, 18688
reassigning, i have a fix
Assignee: ftang → jdunn
how about /rdf/datasource/src/nsFileSystemDataSource.cpp, line 270 -- NS_WITH_SERVICE(nsIPlatformCharset, platformCharset, kPlatformCharsetCID, &rv); ? I get this from http://lxr.mozilla.org/seamonkey/search?string=kPlatformCharsetCID It seems all other files have static, but not this one.
Frank this code is commented out. Should I add the NS_DECLARE_CID(kPlatformCharset) and put it in a comment?
Status: UNCONFIRMED → RESOLVED
Closed: 25 years ago
Resolution: --- → FIXED
closing
Status: RESOLVED → CLOSED
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: