296679 - File, edit and view menus missing from chatzilla

Status: RESOLVED FIXED

(Other Applications :: ChatZilla, defect)

Description

[Andrew Schultz]

The file, edit and view menus are missing from chatzilla with linux suite trunk
2005060403.  They were there with 2005060301, so I'm guessing this is fallout
from bug 295711.

Comment 1

[James Ross]

WFM, Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8b2) Gecko/20050605

Comment 2

[James Ross]

The menus usually don't appear if a startup JS error occurs, which will trigger
a popup dialog with the error in it. If you don't see that, check the Mozilla
console (NOT JS Console) when starting CZ with browser.dom.window.dump.enabled
enabled.

Comment 3

[Andrew Schultz]

no JS errors in the console with dump enabled.

Comment 4

[James Ross]

Does CZ actually work otherwise, then? 'cos that would be very odd indeed.

What is in the menubar according to DOMI?

Comment 5

[Andrew Schultz]

> Does CZ actually work otherwise, then? 'cos that would be very odd indeed.

yes, it's fully functional other than the lack of menus

> What is in the menubar according to DOMI?

all of the menus are in the menubar.  the CSS styles being applied appear to be
the same.  The only difference I noticed was that in the computed style pane,
the missing menus have "height:auto" and the visible menus had "height:16px".

I also backed out xul.css change from bug 295711 to test it out and the menus
came back.  But that seems strange since DOMI showed that the missing menus have
"display:-moz-box"

Comment 6

[James Ross]

Ok, so this isn't actually a CZ bug.

It sounds like the empty menu CSS stuff I remember from the DOMI landing is
being applied initially and not correctly updated when ChatZilla adds the items
to these menus.

Comment 7

[James Ross]

I can see this on Windows now, dunno why it worked before.

Anyway, bug 98997 needs a-fixin'. I'm leaving this one open to catch dups, but
technically this bug is a dup of 98997.

Comment 8

[Benjamin Smedberg]

Silver, can I suggest that you add the <menupopup> statically, and populate *it*
dynamically? That way the :empty designation will not affect you.

Comment 9

[James Ross]

That seems fairly logical (though wrong ;) ). I'll try to do a patch by this
evening, if no-one beats me.

Comment 10

[James Ross]

Attachment: Hack to work around bug 98997

bsmedberg, you're lucky the Menu Manager in CZ copes with the <menupopup/>
already existing. ;)

Comment 11

[James Ross]

Checked in --> FIXED.