296827 - Dragging & dropping text into the Find text box does not enable search buttons or initiate search.

Status: RESOLVED FIXED

(Toolkit :: Find Toolbar, defect)

Description

[Paul Farmer]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-GB; rv:1.7.8) Gecko/20050511 Firefox/1.0.4
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-GB; rv:1.7.8) Gecko/20050511 Firefox/1.0.4

Dropping text (which has been selected and dragged from elsewhere, including the
displayed webpage or another application) into the Find toolbar text box does
not enable the search buttons nor does it initiate the search. Subsequently
giving focus to the text box by clicking into it with the mouse doesn't enable
the buttons, and neither does moving the cursor within the text box with the
cursor keys once it has focus. Only when a further character or backspace is
typed from the keyboard are the buttons enabled.

Reproducible: Always

Steps to Reproduce:
I think I've explained it pretty well above, but here goes:
1. Display the Find toolbar.
2. From the displayed webpage or another application window displaying text,
select some text, then (button 1) click and drag the selected text to the Find
toobar text box.
3. Release the mouse button to drop the selected text into the text box.
4. Note that no search has been initiated and that the search buttons in the
toolbar are disabled.
5. Give focus to the text box in any way you like.
6. Note that you are no further forward.
7. Type a character from the keyboard while the textbox has focus. Note the
miraculous enabling of the search buttons.

Actual Results:  
I made some tea.

Expected Results:  
I'm getting bored now.

Comment 1

[Peter van der Woude [:Peter6]]

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8b2) Gecko/20050606
Firefox/1.0+ ID:2005060607

confirmed ->NEW

one would expect the same behaviour as for searchbar

Comment 2

[Jorge Villalobos [:jorgev] (he/him)]

Attachment: Drag and drop event handler added to find bar

This patch is based on the drag-and-drop behavior done for the URLBar in
http://lxr.mozilla.org/aviary101branch/source/browser/base/content/browser.js

Comment 3

[Jorge Villalobos [:jorgev] (he/him)]

Comment on attachment 185742 [details] [diff] [review]
Drag and drop event handler added to find bar

Find bar component is also used in Help, View Source and View Source Selection.
Corresponding XUL files need to include nsDragAndDrop.js. A fixed patch is on
the way.

Comment 4

[Jorge Villalobos [:jorgev] (he/him)]

Attachment: D&d for find bar in browser, view source and help

Update of previous patch. Added include for nsDragAndDrop.js for Help and View
Source XUL files.

Comment 5

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 185838 [details] [diff] [review]
D&d for find bar in browser, view source and help

You need to ask review from someone specifically.

Comment 6

[Martijn Wargers (dead)]

*** Bug 297989 has been marked as a duplicate of this bug. ***

Comment 7

[Mike Connor [:mconnor]]

Not a blocker, will look at patch rsn.

Comment 8

[Martijn Wargers (dead)]

+      // XXXBlake Workaround caret crash when you try to set the textbox's
value on dropping
+      setTimeout(function(u) { findField.value = u; find(u); }, 0, aXferData.data);
This workaround is not necessary anymore since bug 296464 got fixed.

Comment 9

[Mike Connor [:mconnor]]

Comment on attachment 185838 [details] [diff] [review]
D&d for find bar in browser, view source and help

r=me, but the textbox crash is no more, I already removed the timeout from
where you cribbed that bit, so just remove the timeout and we're good to go.

Comment 10

[Jorge Villalobos [:jorgev] (he/him)]

Attachment: D&d patch without timeout workaround

Eliminated timeout workaround as per comments #8 and #9.

Comment 11

[:Gavin Sharp [email: [e-mail]]]

mozilla/toolkit/components/help/content/help.xul; new revision: 1.28;
mozilla/toolkit/components/typeaheadfind/content/findBar.js; new revision: 1.27;
mozilla/toolkit/components/viewsource/content/viewPartialSource.xul; new
revision: 1.21;
mozilla/toolkit/components/viewsource/content/viewSource.xul; new revision: 1.25;

Comment 12

[Mike Schroepfer]

Comment on attachment 196459 [details] [diff] [review]
D&d patch without timeout workaround

Per bug meeting - approved for 1.8b5 branch.

Comment 13

[Asaf Romano (gone)]

1.8 Branch:
mozilla/toolkit/components/help/content/help.xul 1.26.2.1
mozilla/toolkit/components/typeaheadfind/content/findBar.js 1.21.2.6
mozilla/toolkit/components/viewsource/content/viewPartialSource.xul 1.20.2.1
mozilla/toolkit/components/viewsource/content/viewSource 1.24.2.1