Closed
Bug 296849
Opened 19 years ago
Closed 19 years ago
[BEOS] nsWindow::SetForegroundColor calls nsBaseWidget::SetBackgroundColor
Categories
(Core Graveyard :: Widget: BeOS, defect)
Tracking
(Not tracked)
VERIFIED
DUPLICATE
of bug 298171
People
(Reporter: thesuckiestemail, Unassigned)
References
Details
Attachments
(1 file)
510 bytes,
patch
|
sergei_d
:
review+
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (BeOS; U; BeOS BePC; en-US; rv:1.8b2) Gecko/20050604 Firefox/1.0+
Build Identifier:
nsWindow::SetForegroundColor calls nsBaseWidget::SetBackgroundColor while it
should call SetForegroundColor.
Reproducible: Always
Comment 2•19 years ago
|
||
Looks obvious, but i should check first result of those calls in GFX - is it
SetViewColor or SetHightColor or SetLowColor, and what it should be actually:)
Comment 3•19 years ago
|
||
Comment on attachment 185480 [details] [diff] [review]
calls SetForegroundColor instead
r=sergei_d
Searched through LXR.
It seems there is now use for those color set methods outside widget-internal
"doing nothing".
or like that
http://lxr.mozilla.org/seamonkey/source/widget/src/mac/nsWindow.cpp#358
which is also "internal".
Attachment #185480 -
Flags: review?(sergei_d) → review+
Moved this code into bug 298171 as I wanted to change viewcolor-handling to
improve scrolling and reduce the need to apply different patches.
*** This bug has been marked as a duplicate of 298171 ***
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → DUPLICATE
Updated•10 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•