29699 - Quoted format=flowed msg should flow

Status: VERIFIED WONTFIX

(Core :: DOM: Editor, defect, P3)

Description

[Ben Bucksch (:BenB)]

Additional Comments From [e-mail]  2000-02-29 15:24 in bug #29680:
> Replying to the [format=flowed] message in a plaintext compose window on
> either platform, or in html compose on NT, looks like a reply to an ordinary
> unflowed plaintext message, with hard wraps, and a horizontal scrollbar if I
> resize the window too small.

Yes, this is a bug. Flowed quotes are one of the major advantages of
format=flowed (it solves the problem with lines getting longer by quoting).

Comment 1

[Akkana Peck]

Accepting -- let's get this working right in M15.

I have another bug on the need to change the APIs for InsertAsCitedQuotation
anyway, to pass in whether we're handing it text or html; at the same time I can
indicate whether it's flowed, and not put it inside a pre (I think that's what
it's doing now) in the flowed case.

Comment 2

[Ben Bucksch (:BenB)]

Bug #29699 is related.

Comment 3

[Akkana Peck]

Bug 29557 contains a long and useful discussion of format=flowed quotations, and
suggests that flowed plaintext should be quoted with <blockquote class="flowed">
so that style can distinguish it from quoted html.  I will plan to do that
unless someone has a better idea.

Comment 4

[Ben Bucksch (:BenB)]

Yes, that's the one I meant, I got confused by the many bug windows here :).

Comment 5

[Daniel Bratell]

That (class="flowed") seems like a good idea. 

That replying didn't keep all the flowed information is something I've been 
aware of some time, but I've had no time to look into it with all my work for my 
degrees. 

Comment 6

[Akkana Peck]

I was in the middle of doing this, and changing the umpteen files that one has
to change in order to change an API in the editor, and realized that it didn't
matter because I wasn't doing a single thing differently if the flowed parameter
was set, except to add class=flowed.  And then the editor doesn't know to do
anything about this anyway.

Wouldn't it make more sense for mail to take the blockquote (which is returned
as the node inserted in any case, so mail already has it) and set the
class=flowed parameter there, and not require  special-case code in the editor?

Comment 7

[Ben Bucksch (:BenB)]

akk,
what I'm doing for bug #31906 (see buggy patch there), is to add a all-enclosing
<div class=text_flowed>. You can easily select the quoted flowed msg with
"blockquote div.text_flowed". I don't know, how the editor is written, but I
don't think, you have to hardcode anything there.

Comment 8

[Ben Bucksch (:BenB)]

s/text_flowed/text-flowed

Comment 9

[Akkana Peck]

Okay, it sounds like there's really no need for the editor to change any APIs,
then.  I'm going to close this bug.

Comment 10

[Ben Bucksch (:BenB)]

A dup or so would have been better, but VERIFIYing.

Comment 11

[Ben Bucksch (:BenB)]

Ben Bucksch wrote:
> what I'm doing for bug #31906 (see buggy patch there), is to add a
> all-enclosing <div class=text_flowed>

Nice, but exposes a 4.x bug.

akk wrote:
> Wouldn't it make more sense for mail to take the blockquote (which is returned
> as the node inserted in any case, so mail already has it) and set the
> class=flowed parameter there, and not require  special-case code in the
> editor?

How do I do that?

Comment 12

[Akkana Peck]

nsIDOMElement has a SetAttribute call.  You can QueryInterface between
nsIDOMNode, nsIDOMElement, nsIContent (and probably several other interface
classes) so if you have a node (or a content or whatever), you can get the
element via a QI.

Comment 13

[Ben Bucksch (:BenB)]

akk, ic. I overlooked

akk wrote:
> which is returned as the node inserted in any case

Nice interface. Easy.

Comment 14

[Ben Bucksch (:BenB)]

FYI: Filed bug 45268 about the implementation.