297286 - Changing Color breaks "Set as desktop background"

Status: RESOLVED FIXED

(Toolkit :: UI Widgets, defect, P2)

Description

[Ger Teunis]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050610 Firefox/1.0+
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050610 Firefox/1.0+

When the Color is changed the "Set wallpaper" button doesn't work.

Reproducible: Always

Steps to Reproduce:
1. Right-click a image and select "Set as wallpaper"
2. Change the color
3. Click on "Set wallpaper" button

Actual Results:  
Nothing happens

Expected Results:  
The wallpaper should be set, and the "set as wallpaper" should disappear.

Comment 1

[Adam Guthrie]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050610
Firefox/1.0+ ID:2005061019

Confirming. This is definitely a regression.

Comment 2

[José Jeria]

Seing this as well, no js errors in js console

--> NEW

Comment 3

[José Jeria]

When did this regress?

Comment 4

[Ger Teunis]

(In reply to comment #3)
> When did this regress?

I checked back to 2005-05-30-05-trunk, all have the bug.
Fx 1.0 release did not have this bug.
Anyone knows a ftp with all/more nightly build?

Comment 5

[José Jeria]

(In reply to comment #4)
> Anyone knows a ftp with all/more nightly build?

http://archive.mozilla.org/

Comment 6

[Ger Teunis]

Thanks, it regressed between 20050224 and 20050225 build.
Not that great work tracing this regression down :-)

Comment 7

[Ger Teunis]

(In reply to comment #6)
> Thanks, it regressed between 20050224 and 20050225 build.
> Not that great work tracing this regression down :-)

Forgot to mention:
I've tested the win32 builds
(regressed between 2005-03-24-07-trunk and 2005-03-25-08-trunk)

Comment 8

[José Jeria]

Bugs checked in during that time period:
http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=PhoenixTinderbox&branch=HEAD&branchtype=match&dir=&file=&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=explicit&mindate=2005-03-24+07%3A00%3A00&maxdate=2005-03-25+08%3A00%3A00&cvsroot=%2Fcvsroot

Comment 9

[José Jeria]

cc:ing Mike Connor to see if he knows what bug might have caused this

Comment 10

[:Gavin Sharp [email: [e-mail]]]

This is a regression from Ben's pref dialog rewrite, specifically, the
colorpicker.xml changes.

http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&file=colorpicker.xml&branch=&root=/cvsroot&subdir=mozilla/toolkit/content/widgets&command=DIFF_FRAMESET&rev1=1.7&rev2=1.8

There's something wacky going on with generated events. Ben might not have
considered the use of colorpicker's other than those used by the PrefWindow.

Comment 11

[Asaf Romano (gone)]

-> me for investigation.

Comment 12

[Asaf Romano (gone)]

Attachment: patch

The onchange event in setDefaultBackground.xul reffers to |this.color|; however
the new |_fireEvent| method (in colorpicker.xml) doesn't fire the event
function with the right context object (which should be |aTarget|).

The attached patch also fixes a stupid js warning and the same error in the
preferences binding.

Comment 13

[Mike Connor [:mconnor]]

Comment on attachment 188251 [details] [diff] [review]
patch

please fix the bogus spacing in both places in the var rv = lines

Comment 14

[Asaf Romano (gone)]

Comment on attachment 188251 [details] [diff] [review]
patch

Might be too late for b3

Comment 15

[Asaf Romano (gone)]

and re-nominating...

Comment 16

[Asaf Romano (gone)]

In case this fix will be landed for b3/a2, the preferences dialog (the colors
preferences dialog in particular) should be tested.

Comment 17

[:Gavin Sharp [email: [e-mail]]]

There was bug 298665 filed for the actual widget work (see depends). Guess that
can be duped here now.

Comment 18

[Asaf Romano (gone)]

Checking in colorpicker.xml;
/cvsroot/mozilla/toolkit/content/widgets/colorpicker.xml,v  <--  colorpicker.xml
new revision: 1.10; previous revision: 1.9
done
Checking in preferences.xml;
/cvsroot/mozilla/toolkit/content/widgets/preferences.xml,v  <--  preferences.xml
new revision: 1.22; previous revision: 1.21
done