297369 - Find Toolbar cleared by "/" or "'" but the toolbar status is not reset

Status: RESOLVED WORKSFORME

(Toolkit :: Find Toolbar, defect)

Description

[Jorge Villalobos [:jorgev] (he/him)]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.8) Gecko/20050511 Firefox/1.0.4
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.8) Gecko/20050511 Firefox/1.0.4

There's some odd behavior in the find bar when opening it in different manners.
If you open it using only Ctrl+F, the last search string always appears when
reopening the find bar.
When you reopen it with / or ', though, the find bar textbox is empty _and_ the
find buttons are enabled, as if something was entered. Interestingly enough, if
you reopen with Ctrl+F the same happens: textbox empty and buttons enabled, but
if you change tabs and reopen with Ctrl+F the search string magically appears!

Reproducible: Always

Steps to Reproduce:
1.Open find bar (Ctrl+F).
2.Enter a search string.
3.Close find bar (Esc).
4.Open it again with / or '

Actual Results:  
Find bar textbox appears empty, but find buttons are enabled, as if there was a
search string.

Expected Results:  
Find bar should show the search string that was entered in step 2.

This bug is related with Bug 251989, which I think is invalid or just different,
since it involves highlighting of text.

Comment 1

[Adam Guthrie]

Find as you type should not display the previous entry that you typed in when
doing Ctrl+F -- it's not the same as find. The only bug here is that the buttons
(find next, find previous, etc.) are already enabled when the box pops up --
which is pretty trivial.

Comment 2

[Jorge Villalobos [:jorgev] (he/him)]

(In reply to comment #1)
> Find as you type should not display the previous entry that you typed in when
> doing Ctrl+F -- it's not the same as find. The only bug here is that the buttons
> (find next, find previous, etc.) are already enabled when the box pops up --
> which is pretty trivial.

Changing severity to minor. Actually that's not the only bug. As I pointed out,
reopening the find bar with Ctrl+F after reopening with / or ' produces the same
result: empty find bar and enabled buttons. That _too_ is part of the bug.

Comment 3

[Jorge Villalobos [:jorgev] (he/him)]

Attachment: Patch V1

This patch clears the find bar and find bar buttons when activating with / or
'. Anytime a find is done with / or ', the last find text is cleared, so
reopening with Ctrl+F will produce an empty find textbox and disabled buttons
as well. This also removes the highlighting from Bug 251989.

Comment 4

[Gervase Markham [:gerv]]

This is an automated message, with ID "auto-resolve01".

This bug has had no comments for a long time. Statistically, we have found that
bug reports that have not been confirmed by a second user after three months are
highly unlikely to be the source of a fix to the code.

While your input is very important to us, our resources are limited and so we
are asking for your help in focussing our efforts. If you can still reproduce
this problem in the latest version of the product (see below for how to obtain a
copy) or, for feature requests, if it's not present in the latest version and
you still believe we should implement it, please visit the URL of this bug
(given at the top of this mail) and add a comment to that effect, giving more
reproduction information if you have it.

If it is not a problem any longer, you need take no action. If this bug is not
changed in any way in the next two weeks, it will be automatically resolved.
Thank you for your help in this matter.

The latest beta releases can be obtained from:
Firefox:     http://www.mozilla.org/projects/firefox/
Thunderbird: http://www.mozilla.org/products/thunderbird/releases/1.5beta1.html
Seamonkey:   http://www.mozilla.org/projects/seamonkey/

Comment 5

[Jorge Villalobos [:jorgev] (he/him)]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20050927
Firefox/1.6a1 ID:2005092707
This bug can still be reproduced.

Comment 6

[u63580]

(In reply to comment #1)
> Find as you type should not display the previous entry that you typed in when
> doing Ctrl+F -- it's not the same as find. The only bug here is that the buttons
> (find next, find previous, etc.) are already enabled when the box pops up --
> which is pretty trivial.

Surely this is the real point - ctrl-f, / and ' are not the same thing as each
other, so do different things.

Comment 7

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

The pre finding text is cleared that is sepc of FAYT.
It's not a bug. We designed so.

But the Find Toolbar's status(buttons, hightlight) are not reset that is a bug.

Taking this bug.

Comment 8

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Patch rv1.0

For fix this bug, we need only these code.
+    if (startByChar) {
+      this.fireKeypressEvent(findField.inputField, evt);
+      // In this time, onFindBarInput is called by |fireKeypressEvent|.
+    } else
+      this.onFindBarUpdate();
       ^^^^^^^^^^^^^^^^^^^^^^^
But I made to simple code for |onBrowserKeyPress|.

Comment 9

[Michael Ventnor]

The review for this patch should be assigned to someone else since mconnor is always too busy and misses some bugs.

Comment 10

[Peter Kasting]

(In reply to comment #9)
> The review for this patch should be assigned to someone else since mconnor is
> always too busy and misses some bugs.

The patch on this bug is obsolete with the changes that have happened to the find bar in the last year.  Also the bug itself is half-obsolete now that Quick Find mode does not show mouse-clickable buttons.

In short, this needs another look, not just a patch review.

Comment 11

[Mike Connor [:mconnor]]

Comment on attachment 201966 [details] [diff] [review]
Patch rv1.0

long-bitrotted, if this is still a bug, please recreate the patch for the new binding...

Comment 12

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

I'm resetting bugs which are assigned to me but I'm not working on them and I don't have plan for fixing them in near future.

Comment 13

[Jorge Villalobos [:jorgev] (he/him)]

This is fixed on recent versions of Firefox now that the Quick Find feature doesn't have the search buttons. It also appears that the search string is now consistently kept between the different search modes.

WFM