297668 - Javascript strict warnings in bookmarks.js

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[Romain BEZUT]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050613 Firefox/1.0+
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050613 Firefox/1.0+

Create a new folder in the bookmark manager or while bookmark a page generates 2
javascript strict warnings :

Warning: assignment to undeclared variable value
SourceFile: chrome://browser/content/bookmarks/bookmarks.js
Line: 550

Warning: assignment to undeclared variable isValid
Source File:chrome://browser/content/bookmarks/bookmarks.js
Line:1397

Reproducible: Always

Steps to Reproduce:
1. Bookmark whatever page you want
2. When you have the window wich ask you for a folder, click on the little
triangle on the right
3. Click on "New Folder ..."
4. See with the Javascript Console the 2 warnings (strict warnings have to be
enabled)

Actual Results:  
There are 2 strict warnings in the Javascript Console.

Expected Results:  
Correct theese strict warnings.

Comment 1

[Romain BEZUT]

Attachment: patch

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Romain, please assign bugs to yourself when suppling patches.

Comment 3

[timeless]

Comment on attachment 186215 [details] [diff] [review]
patch

mozilla/browser/components/bookmarks/content/bookmarks.js	1.100

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+2]]

v