Javascript strict warnings in bookmarks.js

VERIFIED FIXED

Status

()

--
trivial
VERIFIED FIXED
14 years ago
13 years ago

People

(Reporter: romain, Assigned: romain)

Tracking

(Blocks: 1 bug)

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 obsolete attachment)

(Assignee)

Description

14 years ago
User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050613 Firefox/1.0+
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050613 Firefox/1.0+

Create a new folder in the bookmark manager or while bookmark a page generates 2
javascript strict warnings :

Warning: assignment to undeclared variable value
SourceFile: chrome://browser/content/bookmarks/bookmarks.js
Line: 550

Warning: assignment to undeclared variable isValid
Source File:chrome://browser/content/bookmarks/bookmarks.js
Line:1397

Reproducible: Always

Steps to Reproduce:
1. Bookmark whatever page you want
2. When you have the window wich ask you for a folder, click on the little
triangle on the right
3. Click on "New Folder ..."
4. See with the Javascript Console the 2 warnings (strict warnings have to be
enabled)

Actual Results:  
There are 2 strict warnings in the Javascript Console.

Expected Results:  
Correct theese strict warnings.
Status: UNCONFIRMED → NEW
Ever confirmed: true
(Assignee)

Comment 1

14 years ago
Created attachment 186215 [details] [diff] [review]
patch
Attachment #186215 - Flags: review?(mconnor)

Updated

14 years ago
Attachment #186215 - Flags: review?(mconnor) → review+
Whiteboard: [checkin needed]
Attachment #186215 - Flags: approval-aviary1.1a2?
Romain, please assign bugs to yourself when suppling patches.
Assignee: nobody → r.bezut
Whiteboard: [checkin needed]

Updated

14 years ago
Attachment #186215 - Flags: approval-aviary1.1a2? → approval-aviary1.1a2+
Whiteboard: [checkin needed][a+]

Comment 3

14 years ago
Comment on attachment 186215 [details] [diff] [review]
patch

mozilla/browser/components/bookmarks/content/bookmarks.js	1.100
Attachment #186215 - Attachment is obsolete: true

Updated

14 years ago
Whiteboard: [checkin needed][a+]
(Assignee)

Updated

14 years ago
Status: NEW → RESOLVED
Last Resolved: 14 years ago
Resolution: --- → FIXED
v
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.