298281 - Implement color-interpolation="linearRGB"

Status: RESOLVED FIXED

(Core :: SVG, enhancement)

Description

[Rob Russell]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050531 Firefox/1.0+
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050531 Firefox/1.0+

color-interpolation="linearRGB" renders the same as color-interpolation="sRGB"
on the linear gradient in the test suite.

Reproducible: Always

Steps to Reproduce:
1. Visit
http://www.w3.org/Graphics/SVG/Test/20030813/htmlframe/full-painting-render-01-b.html
with Deer Park Alpha 1.1
2. Compare the three gradients.
3. The differences are described in the text on the page. 

Actual Results:  
The three examples look the same.

Expected Results:  
The third example should be different (read the text in the test).

Comment 1

[Jonathan Watt [:jwatt]]

Spec. link: http://www.w3.org/TR/SVG/painting.html#ColorInterpolationProperties

Comment 2

[Scooter Morris]

Unfortunately, cairo does not support multiple color spaces, so at this point,
we're pretty much stuck with what we've got, unless I'm missing something.  When
cairo does provide the support, we can provide the SVG support.

Comment 3

[Holger Will]

converting sRGB to linearRGB is a simple gamma correction, it can be expressed
as an svg filter ( which allready works in mozilla ! yay :-) ):

<filter id="toLinearRGB" filterUnits="objectBoundingBox" x="0" y="0" width="1"
height="1">
  <feComponentTransfer color-interpolation-filters="sRGB">
     <feFuncR type="gamma" amplitude="1" exponent="0.416666666666" offset="0"/>
     <feFuncG type="gamma" amplitude="1" exponent="0.416666666666" offset="0"/>
     <feFuncB type="gamma" amplitude="1" exponent="0.416666666666" offset="0"/>
     <feFuncA type="gamma" amplitude="1" exponent="0.416666666666" offset="0"/>
  </feComponentTransfer>
</filter>

here is the site where i found this information:
http://www.sjbrown.co.uk/index.php?article=gamma

this can be used as a workaround if you need linearRGB. 

Comment 4

[Holger Will]

oops, this is not 100% correct, it should be exponent="0.454545454545" , sorry !

Comment 6

[Martin Funcich]

Not sure what the procedure is to mark a CSS feature in MDN as "not implemented yet", so I'm dropping a note here that this feature should be marked in MDN as "not implemented yet" :)

(Personally, I find this feature very interesting for producing very natural-looking colour blending, possibly with a view to HDR colour in the browser. In conjunction with bloom/blur/spread/convolution filters, very lush appearances can be achieved.)

Comment 7

[Martin Funcich]

(In reply to Martin Funcich from comment #6)
> Not sure what the procedure is to mark a CSS feature in MDN as "not
> implemented yet", so I'm dropping a note here that this feature should be
> marked in MDN as "not implemented yet" :)
> 
> (Personally, I find this feature very interesting for producing very
> natural-looking colour blending, possibly with a view to HDR colour in the
> browser. In conjunction with bloom/blur/spread/convolution filters, very
> lush appearances can be achieved.)

Oooh, just noticed there is a color-interpolation-filters property for SVG filters that defaults to linearRGB and appears to be already working ... nice ...

Comment 8

[Robert Longson [:longsonr]]

(In reply to Martin Funcich from comment #6)
> Not sure what the procedure is to mark a CSS feature in MDN as "not
> implemented yet", so I'm dropping a note here that this feature should be
> marked in MDN as "not implemented yet" :)
> 

It is implemented for mask elements though, but not elsewhere.

Comment 9

[BugBot [:suhaib / :marco/ :calixte]]

The severity field for this bug is relatively low, S3. However, the bug has 11 votes.
:jwatt, could you consider increasing the bug severity?

For more information, please visit auto_nag documentation.

Comment 10

[BugBot (nomail) [:suhaib / :marco/ :calixte]]

The last needinfo from me was triggered in error by recent activity on the bug. I'm clearing the needinfo since this is a very old bug and I don't know if it's still relevant.

Comment 11

[Robert Longson [:longsonr]]

Attachment: Bug 298281 - implement color-interpolation: linearRGB for gradients r=emilio

Comment 12

[Robert Longson [:longsonr]]

https://treeherder.mozilla.org/jobs?repo=try&revision=e205f5f5a045a868da5e60ed9b78f8374ac68a50

Comment 13

[Robert Longson [:longsonr]]

https://treeherder.mozilla.org/jobs?repo=try&revision=9ee0d8e5646baba69ea46afd408ccfed810c84e3

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1cb2802bb09b
implement color-interpolation: linearRGB for gradients r=emilio

Comment 15

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/43713 for changes under testing/web-platform/tests

Comment 16

[Cristina Horotan [:chorotan]]

Backed out changeset 1cb2802bb09b (bug 298281) for causing build bustage at nsCSSRenderingGradients.h

Backout: https://hg.mozilla.org/integration/autoland/rev/aeb951a438d6f33812c2b4d5cc70aaabbef7a37e

Failure push: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=1cb2802bb09b7a1c7a850be8f432a0e60253c6b2

Failure log: https://treeherder.mozilla.org/logviewer?job_id=440534116&repo=autoland&lineNumber=93711

Comment 17

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR was closed without merging

Comment 18

[Robert Longson [:longsonr]]

https://treeherder.mozilla.org/jobs?repo=try&revision=5ef40712cef211ff25b5f1ed3b6fabc3891fe4fd

Comment 19

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6a3bba37bd22
implement color-interpolation: linearRGB for gradients r=emilio

Comment 20

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/6a3bba37bd22

Comment 21

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 22

[Pascal Chevrel:pascalc]

Robert, is that something worth mentioning in our release notes (general or MDN)?

Comment 23

[Robert Longson [:longsonr]]

Release Note Request (optional, but appreciated)
[Why is this notable]:
We now implement linearRGB interpolation for SVG gradients.
[Affects Firefox for Android]:
yes
[Suggested wording]:
We now implement linearRGB interpolation for SVG gradients, as well as the existing sRGB interpolation. You can choose which to use via the color-interpolation property.
[Links (documentation, blog post, etc)]:
http://www.w3.org/Graphics/SVG/Test/20030813/htmlframe/full-painting-render-01-b.html
https://developer.mozilla.org/en-US/docs/Web/SVG/Attribute/color-interpolation

Comment 24

[Pascal Chevrel:pascalc]

Note added to 123 nightly release notes in the Web Standards section with a link to MDN, thanks.

Comment 25

[Sebastian Zartner [:sebo]]

The browser compat data should also be updated (actually added) to reflect that change.

Sebastian

Comment 26

[Dave Letorey]

• Content PR
• Firefox Release PR
• Related BCD PR