298508 - Numeric comparison performed on strings in editwhines.cgi

Status: RESOLVED FIXED

(Bugzilla :: Whining, defect)

Description

[A. Karl Kornel]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.2) Gecko/20040804 Netscape/7.2 (ax)
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.2) Gecko/20040804 Netscape/7.2 (ax)

in editwhines.cgi (the tip version), $o_mailto and $mailto are defined on lines
228-229:

> my $o_mailto      = $cgi->param("orig_mailto_$sid");
> my $mailto        = $cgi->param("mailto_$sid");

Later on, they are compared using a numeric comparison, on line 272-275:

> if ( ($o_day  ne $day) ||
>      ($o_time ne $time) ||
>      ($o_mailto != $mailto) ||
>      ($o_mailto_type != $mailto_type) ){ 

This produces the following error 2 times in the Apache error_log:

editwhines.cgi: Argument "******" isn't numeric in numeric ne (!=) at
/Library/WebServer/Documents/bugzilla-new/editwhines.cgi line 272.

Reproducible: Always

Steps to Reproduce:




$o_mailto and $mailto may also be set in lines 235-236, but would still be set
to string values.

Comment 1

[A. Karl Kornel]

Attachment: Change numeric conversion to string conversion

Modifies numeric comparison between $mailto and $o_mailto to use a string
comparison on line 274.

Assumes this bug is valid & that a string conversion is needed.

Comment 2

[A. Karl Kornel]

Comment on attachment 187064 [details] [diff] [review]
Change numeric conversion to string conversion

It's been 7+ days since the request was raised.  Requesting review from
LpSolit...

Comment 3

[Frédéric Buclin]

Comment on attachment 187064 [details] [diff] [review]
Change numeric conversion to string conversion

r=LpSolit

Comment 4

[Frédéric Buclin]

I merged this patch manually with the one from bug 298510, first because they
conflict, and also because this one is bitrotten due to the other one.

Comment 5

[Frédéric Buclin]

*** Bug 300018 has been marked as a duplicate of this bug. ***