298562 - search plugin doesn't work if properties are one a single line (causes Exception in search.xml)

Status: RESOLVED WONTFIX

(Firefox :: Search, defect)

Description

[Henrik Gemal]

this search plugin doesn't work:
<search
name="TDC.dk" method="GET" action="http://search.tdc.dk/">
<input name="q" user>
</search>

while this one does:
<search
name="TDC.dk"
method="GET"
action="http://search.tdc.dk/">
<input name="q" user>
</search>

the difference is the new lines

I'm getting this:

Error: [Exception... "Component returned failure code: 0x8000ffff
(NS_ERROR_UNEXPECTED) [nsIInternetSearchService.GetInternetSearchURL]" 
nsresult: "0x8000ffff (NS_ERROR_UNEXPECTED)"  location: "JS frame ::
chrome://browser/content/search.xml :: onTextEntered :: line 201"  data: no]
Source File: chrome://browser/content/search.xml
Line: 201

Comment 1

[Andrew Tonner]

Does it work if you make it well-formed?

Comment 2

[:Gavin Sharp [email: [e-mail]]]

I don't plan on making Firefox 2's new sherlock parser support this, since there are virtually no plugins that are broken in this way. I see no advantage to allowing a different format. The new parser will however ignore such invalid plugins instead of throwing exceptions.

Henrik, given that, do you agree with closing this bug as WONTFIX?

Comment 3

[:Gavin Sharp [email: [e-mail]]]

Marking WONTFIX, since I didn't fix it in the new search service ;)