Spun off from bug 286446.
Given a complex message, such as:
After detaching the attachment, the resulting message includes two copies of
the text/html body, one of which is hidden between MIME boundaries (without
headers of its own):
OK OK OK OK
<html>OK OK OK OK</html>
<html>COPY, DOESN'T BELONG HERE</html>
blah blah blah
Steps to reproduce:
1) integrate attachment 177627 [details] into your mail system
2) View the message; delete and/or detach the Joe.doc att't.
3) View the resulting message's source
3) Bogus MIME structure observed
3) Correct MIME structure
This bug is holding back my mail archiving. I would like to save attachments
without having my mail format butched.
This is a scary one, if it happens to you (it happened to me)
I think this should block SeaMonkey's release because it's a major functionality
that is broken and causing bloat.
If you want this bug fixed in 1.0b, you should nominate it for 1.8b5. The
relevant code is shared and 1.0b will be released off of 1.8b5, whatever that is.
See my previous comment for the reason.
David, I'll let you decide what to do with this bug.
I'll try to fix it. Changing this code is risky, however.
Created attachment 197455 [details] [diff] [review]
don't display cached part when stripping attachments.
(In reply to comment #8)
> don't display cached part when stripping attachments.
?? Does that fix really belong to this bug?
Comment on attachment 197455 [details] [diff] [review]
I'll let this bake on the trunk for a little bit, but if everything is ok, I'd
like to check it into the branch as well.
>> ?? Does that fix really belong to this bug?
yes, it does - it was the call to display the cached part (the multipart
alternative that we've cached for display) that was causing us to write out the
extra copy of the body.
Please re-ping me when you feel this has baked enough and I'll approve the fix.
When this bug is worked on, perhaps two more attachment-deletion related errors
can be also fixed?
1. When an attachment is deleted from a message where the sender had requested a
receipt notification ("Return-receipt-to:" header, probably the same with
"Disposion-Notification-to:"), a popup window appears again, asking if the
notification shall be sent. This should not happen.
2. After having deleted an attachment, the junk status of the message is set to
"unknown". The junk status should not change upon attachment deletion.
(Or should a new bug be opened for these?)
I've just tried TB 1.6a1+0928, and this patch appears to have fixed the reported
problem. Thanks, David!
great, thx, Mike - pinging mscott for a=, per his request.