setting authentication to LDAP,DB fails

RESOLVED FIXED in Bugzilla 2.20

Status

()

Bugzilla
Bugzilla-General
--
major
RESOLVED FIXED
13 years ago
13 years ago

People

(Reporter: glob, Assigned: A. Karl Kornel)

Tracking

(Blocks: 1 bug)

unspecified
Bugzilla 2.20
Bug Flags:
approval +
blocking2.20 +

Details

Attachments

(1 attachment)

(Reporter)

Description

13 years ago
setting authentication to LDAP,DB fails; once the parameter is set,
authentication results in the following error:

file error - account/auth/ldap,db-error.html.tmpl: not found
(Reporter)

Comment 1

13 years ago
there's an LDAP config problem with my setup, the ldap module is returning
AUTH_ERROR.

i suspect this is a code that we should be treating as a failure at line 115 of
Auth.pm
(Assignee)

Comment 2

13 years ago
This might be a bigger problem than just LDAP,DB.

I'm working on a NIS module.  If I set the parameter to NIS,DB and NIS generates
an AUTH_ERROR, I get a similar error message (file error -
account/auth/nis,db-error.html.tmpl: not found).

If this is true, it might mean that this problem will appear whenever more than
one auth. method is selected and an AUTH_ERROR is returned.
(Assignee)

Comment 3

13 years ago
More info, and a possible source:

It looks like Bugzilla/AUth/Login/WWW/CGI.pm calls Bugzilla::Auth::authenticate,
which takes care of calling each method in turn.  The processing for the
AUTH_ERROR result takes place in CGI.pm line 119.  It immediately calls
ThrowCodeError, but it never seems to determine which class threw the error.
(Assignee)

Updated

13 years ago
Blocks: 297822
(Assignee)

Updated

13 years ago
Flags: blocking2.20?
(Assignee)

Comment 4

13 years ago
Created attachment 188006 [details] [diff] [review]
Patch v1

OK, here's version 1 of a patch to fix this problem.  Thanks to Zornreich's
observations on IRC, this became deceptively simple (I hope).

Requesting review from kiko.
Attachment #188006 - Flags: review?(kiko)
Fwiw without having LDAP to test this with, this looks good to me by inspection.
Assignee: general → karl
OS: Windows XP → All
(Assignee)

Comment 6

13 years ago
(In reply to comment #5)
> Fwiw without having LDAP to test this with, this looks good to me by inspection.

I don't have LDAP access either.  I was able to confirm that errors from my NIS
module were being displayed properly (see bug 297822, I have 'NIS,DB' as my list
of verification methods to try).

glob: You originally reported this.  Assuming you're using LDAP and can try the
patch, does it work for you?
Status: NEW → ASSIGNED
(In reply to comment #6)
> glob: You originally reported this.  Assuming you're using LDAP and can try the
> patch, does it work for you?

Maybe you want to ask Byron for review then?
Whiteboard: [patch awaiting review]
(Assignee)

Comment 8

13 years ago
Comment on attachment 188006 [details] [diff] [review]
Patch v1

wurblzap: Good idea!

bugzilla@glob.com.au: Does this patch fix your problem?
Attachment #188006 - Flags: review?(bugzilla)
(Reporter)

Comment 9

13 years ago
Comment on attachment 188006 [details] [diff] [review]
Patch v1

much better :)	i can now actually see the ldap error message.
Attachment #188006 - Flags: review?(bugzilla) → review+
Byron, Karl -- do we really need the second-review here, or was it requested by
accident?
(Assignee)

Comment 11

13 years ago
bugzilla@glob.com: Was the review+ also a code review?  If so, please cancel the
review? for kiko and ask for approval, or tell me to do it 8-)
(Reporter)

Comment 12

13 years ago
Comment on attachment 188006 [details] [diff] [review]
Patch v1

i'm happy with the code, and we probably don't need kiko's review.
Attachment #188006 - Flags: review?(kiko)

Updated

13 years ago
Flags: approval?
Whiteboard: [patch awaiting review]

Updated

13 years ago
Target Milestone: --- → Bugzilla 2.20
Flags: blocking2.20?
Flags: blocking2.20+
Flags: approval?
Flags: approval+

Comment 13

13 years ago
Checking in Bugzilla/Auth.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Auth.pm,v  <--  Auth.pm
new revision: 1.10; previous revision: 1.9
done
Checking in Bugzilla/Auth/Login/WWW/CGI.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Auth/Login/WWW/CGI.pm,v  <--  CGI.pm
new revision: 1.12; previous revision: 1.11
done
Status: ASSIGNED → RESOLVED
Last Resolved: 13 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.