setting authentication to LDAP,DB fails; once the parameter is set, authentication results in the following error: file error - account/auth/ldap,db-error.html.tmpl: not found
there's an LDAP config problem with my setup, the ldap module is returning AUTH_ERROR. i suspect this is a code that we should be treating as a failure at line 115 of Auth.pm
This might be a bigger problem than just LDAP,DB. I'm working on a NIS module. If I set the parameter to NIS,DB and NIS generates an AUTH_ERROR, I get a similar error message (file error - account/auth/nis,db-error.html.tmpl: not found). If this is true, it might mean that this problem will appear whenever more than one auth. method is selected and an AUTH_ERROR is returned.
More info, and a possible source: It looks like Bugzilla/AUth/Login/WWW/CGI.pm calls Bugzilla::Auth::authenticate, which takes care of calling each method in turn. The processing for the AUTH_ERROR result takes place in CGI.pm line 119. It immediately calls ThrowCodeError, but it never seems to determine which class threw the error.
Created attachment 188006 [details] [diff] [review] Patch v1 OK, here's version 1 of a patch to fix this problem. Thanks to Zornreich's observations on IRC, this became deceptively simple (I hope). Requesting review from kiko.
Fwiw without having LDAP to test this with, this looks good to me by inspection.
(In reply to comment #5) > Fwiw without having LDAP to test this with, this looks good to me by inspection. I don't have LDAP access either. I was able to confirm that errors from my NIS module were being displayed properly (see bug 297822, I have 'NIS,DB' as my list of verification methods to try). glob: You originally reported this. Assuming you're using LDAP and can try the patch, does it work for you?
(In reply to comment #6) > glob: You originally reported this. Assuming you're using LDAP and can try the > patch, does it work for you? Maybe you want to ask Byron for review then?
Comment on attachment 188006 [details] [diff] [review] Patch v1 wurblzap: Good idea! firstname.lastname@example.org: Does this patch fix your problem?
Comment on attachment 188006 [details] [diff] [review] Patch v1 much better :) i can now actually see the ldap error message.
Byron, Karl -- do we really need the second-review here, or was it requested by accident?
email@example.com: Was the review+ also a code review? If so, please cancel the review? for kiko and ask for approval, or tell me to do it 8-)
Comment on attachment 188006 [details] [diff] [review] Patch v1 i'm happy with the code, and we probably don't need kiko's review.
Checking in Bugzilla/Auth.pm; /cvsroot/mozilla/webtools/bugzilla/Bugzilla/Auth.pm,v <-- Auth.pm new revision: 1.10; previous revision: 1.9 done Checking in Bugzilla/Auth/Login/WWW/CGI.pm; /cvsroot/mozilla/webtools/bugzilla/Bugzilla/Auth/Login/WWW/CGI.pm,v <-- CGI.pm new revision: 1.12; previous revision: 1.11 done