298659 - setting authentication to LDAP,DB fails

Status: RESOLVED FIXED

(Bugzilla :: Bugzilla-General, defect)

Description

[:glob ✱]

setting authentication to LDAP,DB fails; once the parameter is set,
authentication results in the following error:

file error - account/auth/ldap,db-error.html.tmpl: not found

Comment 1

[:glob ✱]

there's an LDAP config problem with my setup, the ldap module is returning
AUTH_ERROR.

i suspect this is a code that we should be treating as a failure at line 115 of
Auth.pm

Comment 2

[A. Karl Kornel]

This might be a bigger problem than just LDAP,DB.

I'm working on a NIS module.  If I set the parameter to NIS,DB and NIS generates
an AUTH_ERROR, I get a similar error message (file error -
account/auth/nis,db-error.html.tmpl: not found).

If this is true, it might mean that this problem will appear whenever more than
one auth. method is selected and an AUTH_ERROR is returned.

Comment 3

[A. Karl Kornel]

More info, and a possible source:

It looks like Bugzilla/AUth/Login/WWW/CGI.pm calls Bugzilla::Auth::authenticate,
which takes care of calling each method in turn.  The processing for the
AUTH_ERROR result takes place in CGI.pm line 119.  It immediately calls
ThrowCodeError, but it never seems to determine which class threw the error.

Comment 4

[A. Karl Kornel]

Attachment: Patch v1

OK, here's version 1 of a patch to fix this problem.  Thanks to Zornreich's
observations on IRC, this became deceptively simple (I hope).

Requesting review from kiko.

Comment 5

[Marc Schumann [:Wurblzap]]

Fwiw without having LDAP to test this with, this looks good to me by inspection.

Comment 6

[A. Karl Kornel]

(In reply to comment #5)
> Fwiw without having LDAP to test this with, this looks good to me by inspection.

I don't have LDAP access either.  I was able to confirm that errors from my NIS
module were being displayed properly (see bug 297822, I have 'NIS,DB' as my list
of verification methods to try).

glob: You originally reported this.  Assuming you're using LDAP and can try the
patch, does it work for you?

Comment 7

[Marc Schumann [:Wurblzap]]

(In reply to comment #6)
> glob: You originally reported this.  Assuming you're using LDAP and can try the
> patch, does it work for you?

Maybe you want to ask Byron for review then?

Comment 8

[A. Karl Kornel]

Comment on attachment 188006 [details] [diff] [review]
Patch v1

wurblzap: Good idea!

[e-mail]: Does this patch fix your problem?

Comment 9

[:glob ✱]

Comment on attachment 188006 [details] [diff] [review]
Patch v1

much better :)	i can now actually see the ldap error message.

Comment 10

[Marc Schumann [:Wurblzap]]

Byron, Karl -- do we really need the second-review here, or was it requested by
accident?

Comment 11

[A. Karl Kornel]

[e-mail]: Was the review+ also a code review?  If so, please cancel the
review? for kiko and ask for approval, or tell me to do it 8-)

Comment 12

[:glob ✱]

Comment on attachment 188006 [details] [diff] [review]
Patch v1

i'm happy with the code, and we probably don't need kiko's review.

Comment 13

[Max Kanat-Alexander]

Checking in Bugzilla/Auth.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Auth.pm,v  <--  Auth.pm
new revision: 1.10; previous revision: 1.9
done
Checking in Bugzilla/Auth/Login/WWW/CGI.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Auth/Login/WWW/CGI.pm,v  <--  CGI.pm
new revision: 1.12; previous revision: 1.11
done