migrate Group.pm from a simple module to a class

RESOLVED FIXED in Bugzilla 2.22

Status

()

Bugzilla
Administration
--
enhancement
RESOLVED FIXED
13 years ago
13 years ago

People

(Reporter: timello, Assigned: timello)

Tracking

(Blocks: 1 bug)

2.19.3
Bugzilla 2.22
Dependency tree / graph
Bug Flags:
approval +

Details

Attachments

(1 attachment, 2 obsolete attachments)

(Assignee)

Description

13 years ago
User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.6) Gecko/20050524 Firefox/1.0 (Ubuntu package 1.0.2 MFSA2005-44)
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.6) Gecko/20050524 Firefox/1.0 (Ubuntu package 1.0.2 MFSA2005-44)

There is only one routine at the Group.pm. We could upgrade Group.pm to a class
instead of a simple module, following the bug 294160 class proposal.

Reproducible: Always

Steps to Reproduce:
(Assignee)

Comment 1

13 years ago
Created attachment 187425 [details] [diff] [review]
v1: adding class definitions and pod docs.
Attachment #187425 - Flags: review?(LpSolit)
(Assignee)

Updated

13 years ago
Blocks: 240086

Comment 2

13 years ago
Yep, I agree. I thought I had already filed a bug for this, but I guess not.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Target Milestone: --- → Bugzilla 2.22
Version: unspecified → 2.19.3
(Assignee)

Updated

13 years ago
Assignee: administration → timello
(Assignee)

Updated

13 years ago
Status: NEW → ASSIGNED

Comment 3

13 years ago
Comment on attachment 187425 [details] [diff] [review]
v1: adding class definitions and pod docs.

> # The Original Code is the Bugzilla Bug Tracking System.
> #
>-# The Initial Developer of the Original Code is Netscape Communications
>-# Corporation. Portions created by Netscape are
>-# Copyright (C) 1998 Netscape Communications Corporation. All
>-# Rights Reserved.
>-#
> # Contributor(s): Joel Peshkin <bugreport@peshkin.net>
> #                 Erik Stambaugh <erik@dasbistro.com>
>+#                 Tiago R. Mello <timello@async.com.br>

Not sure you are allowed to remove the reference to Netscape Corp. You should
ask justdave.


>-use Bugzilla::Config;
>+use Bugzilla;
>+use Bugzilla::Util;
>+use Bugzilla::Error;

I think you still need Bugzilla::Config, as it provides Param().


>+=head1 NAME
>+
>+Bugzilla::Group - Object for a Bugzilla groups.

s/groups/group/


>+    my $user_reg_exp = $group->user_reg_exp;

Nit: I prefer regexp than reg_exp


mkanat, could you review this patch too? Maybe I missed something.
Attachment #187425 - Flags: review?(mkanat)
Attachment #187425 - Flags: review?(LpSolit)
Attachment #187425 - Flags: review-
(Assignee)

Comment 4

13 years ago
Created attachment 187655 [details] [diff] [review]
v2: some fixes.
Attachment #187425 - Attachment is obsolete: true
Attachment #187655 - Flags: review?(mkanat)
(Assignee)

Updated

13 years ago
Attachment #187655 - Flags: review?(kiko)
(Assignee)

Comment 5

13 years ago
Created attachment 187665 [details] [diff] [review]
v3: missing Bugzilla::Config
(Assignee)

Updated

13 years ago
Attachment #187655 - Attachment is obsolete: true
Attachment #187665 - Flags: review?(LpSolit)
(Assignee)

Updated

13 years ago
Attachment #187655 - Flags: review?(mkanat)
Attachment #187655 - Flags: review?(kiko)

Updated

13 years ago
Attachment #187425 - Flags: review?(mkanat)

Comment 6

13 years ago
Comment on attachment 187665 [details] [diff] [review]
v3: missing Bugzilla::Config

r=LpSolit
Attachment #187665 - Flags: review?(LpSolit)
Attachment #187665 - Flags: review?
Attachment #187665 - Flags: review+

Updated

13 years ago
Attachment #187665 - Flags: review? → review?(mkanat)

Updated

13 years ago
Attachment #187665 - Flags: review?(mkanat) → review+
(Assignee)

Updated

13 years ago
Flags: approval?
(Assignee)

Updated

13 years ago
Blocks: 294160

Updated

13 years ago
Blocks: 278579
Flags: approval? → approval+

Comment 7

13 years ago
Checking in Bugzilla/Group.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Group.pm,v  <--  Group.pm
new revision: 1.2; previous revision: 1.1
done
Status: ASSIGNED → RESOLVED
Last Resolved: 13 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.