User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.6) Gecko/20050524 Firefox/1.0 (Ubuntu package 1.0.2 MFSA2005-44) Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.6) Gecko/20050524 Firefox/1.0 (Ubuntu package 1.0.2 MFSA2005-44) There is only one routine at the Group.pm. We could upgrade Group.pm to a class instead of a simple module, following the bug 294160 class proposal. Reproducible: Always Steps to Reproduce:
Created attachment 187425 [details] [diff] [review] v1: adding class definitions and pod docs.
Yep, I agree. I thought I had already filed a bug for this, but I guess not.
Comment on attachment 187425 [details] [diff] [review] v1: adding class definitions and pod docs. > # The Original Code is the Bugzilla Bug Tracking System. > # >-# The Initial Developer of the Original Code is Netscape Communications >-# Corporation. Portions created by Netscape are >-# Copyright (C) 1998 Netscape Communications Corporation. All >-# Rights Reserved. >-# > # Contributor(s): Joel Peshkin <firstname.lastname@example.org> > # Erik Stambaugh <email@example.com> >+# Tiago R. Mello <firstname.lastname@example.org> Not sure you are allowed to remove the reference to Netscape Corp. You should ask justdave. >-use Bugzilla::Config; >+use Bugzilla; >+use Bugzilla::Util; >+use Bugzilla::Error; I think you still need Bugzilla::Config, as it provides Param(). >+=head1 NAME >+ >+Bugzilla::Group - Object for a Bugzilla groups. s/groups/group/ >+ my $user_reg_exp = $group->user_reg_exp; Nit: I prefer regexp than reg_exp mkanat, could you review this patch too? Maybe I missed something.
Created attachment 187655 [details] [diff] [review] v2: some fixes.
Comment on attachment 187665 [details] [diff] [review] v3: missing Bugzilla::Config r=LpSolit
Checking in Bugzilla/Group.pm; /cvsroot/mozilla/webtools/bugzilla/Bugzilla/Group.pm,v <-- Group.pm new revision: 1.2; previous revision: 1.1 done