Closed
Bug 298931
Opened 19 years ago
Closed 19 years ago
migrate Group.pm from a simple module to a class
Categories
(Bugzilla :: Administration, task)
Tracking
()
RESOLVED
FIXED
Bugzilla 2.22
People
(Reporter: timello, Assigned: timello)
References
(Blocks 1 open bug)
Details
Attachments
(1 file, 2 obsolete files)
3.97 KB,
patch
|
LpSolit
:
review+
mkanat
:
review+
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.6) Gecko/20050524 Firefox/1.0 (Ubuntu package 1.0.2 MFSA2005-44) Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.6) Gecko/20050524 Firefox/1.0 (Ubuntu package 1.0.2 MFSA2005-44) There is only one routine at the Group.pm. We could upgrade Group.pm to a class instead of a simple module, following the bug 294160 class proposal. Reproducible: Always Steps to Reproduce:
Assignee | ||
Comment 1•19 years ago
|
||
Attachment #187425 -
Flags: review?(LpSolit)
Comment 2•19 years ago
|
||
Yep, I agree. I thought I had already filed a bug for this, but I guess not.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Target Milestone: --- → Bugzilla 2.22
Version: unspecified → 2.19.3
Assignee | ||
Updated•19 years ago
|
Assignee: administration → timello
Assignee | ||
Updated•19 years ago
|
Status: NEW → ASSIGNED
Comment 3•19 years ago
|
||
Comment on attachment 187425 [details] [diff] [review] v1: adding class definitions and pod docs. > # The Original Code is the Bugzilla Bug Tracking System. > # >-# The Initial Developer of the Original Code is Netscape Communications >-# Corporation. Portions created by Netscape are >-# Copyright (C) 1998 Netscape Communications Corporation. All >-# Rights Reserved. >-# > # Contributor(s): Joel Peshkin <bugreport@peshkin.net> > # Erik Stambaugh <erik@dasbistro.com> >+# Tiago R. Mello <timello@async.com.br> Not sure you are allowed to remove the reference to Netscape Corp. You should ask justdave. >-use Bugzilla::Config; >+use Bugzilla; >+use Bugzilla::Util; >+use Bugzilla::Error; I think you still need Bugzilla::Config, as it provides Param(). >+=head1 NAME >+ >+Bugzilla::Group - Object for a Bugzilla groups. s/groups/group/ >+ my $user_reg_exp = $group->user_reg_exp; Nit: I prefer regexp than reg_exp mkanat, could you review this patch too? Maybe I missed something.
Attachment #187425 -
Flags: review?(mkanat)
Attachment #187425 -
Flags: review?(LpSolit)
Attachment #187425 -
Flags: review-
Assignee | ||
Comment 4•19 years ago
|
||
Attachment #187425 -
Attachment is obsolete: true
Attachment #187655 -
Flags: review?(mkanat)
Assignee | ||
Updated•19 years ago
|
Attachment #187655 -
Flags: review?(kiko)
Assignee | ||
Comment 5•19 years ago
|
||
Assignee | ||
Updated•19 years ago
|
Attachment #187655 -
Attachment is obsolete: true
Attachment #187665 -
Flags: review?(LpSolit)
Assignee | ||
Updated•19 years ago
|
Attachment #187655 -
Flags: review?(mkanat)
Attachment #187655 -
Flags: review?(kiko)
Updated•19 years ago
|
Attachment #187425 -
Flags: review?(mkanat)
Comment 6•19 years ago
|
||
Comment on attachment 187665 [details] [diff] [review] v3: missing Bugzilla::Config r=LpSolit
Attachment #187665 -
Flags: review?(LpSolit)
Attachment #187665 -
Flags: review?
Attachment #187665 -
Flags: review+
Updated•19 years ago
|
Attachment #187665 -
Flags: review? → review?(mkanat)
Updated•19 years ago
|
Attachment #187665 -
Flags: review?(mkanat) → review+
Assignee | ||
Updated•19 years ago
|
Flags: approval?
Updated•19 years ago
|
Blocks: bz-majorarch
Updated•19 years ago
|
Flags: approval? → approval+
Comment 7•19 years ago
|
||
Checking in Bugzilla/Group.pm; /cvsroot/mozilla/webtools/bugzilla/Bugzilla/Group.pm,v <-- Group.pm new revision: 1.2; previous revision: 1.1 done
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•