Closed
Bug 298962
Opened 20 years ago
Closed 20 years ago
Remove nssBestCertificate related dead code
Categories
(NSS :: Libraries, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
3.11
People
(Reporter: wtc, Assigned: wtc)
Details
Attachments
(1 file)
|
3.31 KB,
patch
|
julien.pierre
:
review+
nelson
:
superreview+
|
Details | Diff | Splinter Review |
In bug 135521, nssBestCertificate_SetArgs and nssBestCertificate_Callback
were removed, but the removal was not done cleanly. Some dead code is
still around.
|
Assignee | |
Comment 1•20 years ago
|
||
Removed unused functions nssBestCertificate_SetArgs and
nssBestCertificate_Callback and unused type nssBestCertificateCB.
It is easy to verify with LXR that they are unused.
(The two functions used to be declared in lib/pki/pkim.h.)
Attachment #187462 -
Flags: superreview?(nelson)
Attachment #187462 -
Flags: review?(julien.pierre.bugs)
|
||
Updated•20 years ago
|
Attachment #187462 -
Flags: review?(julien.pierre.bugs) → review+
|
|
||
Comment 2•20 years ago
|
||
Comment on attachment 187462 [details] [diff] [review]
Proposed patch
I'm all for removing dead code.
Attachment #187462 -
Flags: superreview?(nelson) → superreview+
|
|
Assignee | |
Comment 3•20 years ago
|
||
Patch checked in on the NSS trunk for NSS 3.11.
Checking in certificate.c;
/cvsroot/mozilla/security/nss/lib/pki/certificate.c,v <-- certificate.c
new revision: 1.55; previous revision: 1.54
done
Checking in pkitm.h;
/cvsroot/mozilla/security/nss/lib/pki/pkitm.h,v <-- pkitm.h
new revision: 1.14; previous revision: 1.13
done
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
Target Milestone: --- → 3.11
You need to log in
before you can comment on or make changes to this bug.
Description
•