Sanitycheck check for submitter ids takes a long time on large sites

RESOLVED FIXED in Bugzilla 2.20

Status

()

RESOLVED FIXED
14 years ago
14 years ago

People

(Reporter: bugreport, Assigned: bugreport)

Tracking

2.19.3
Bugzilla 2.20
Bug Flags:
approval +
approval2.20 +

Details

Attachments

(1 attachment)

(Assignee)

Description

14 years ago
Easy fix... submitter id index should include bug id.
(Assignee)

Comment 1

14 years ago
Created attachment 187679 [details] [diff] [review]
Add bug_id to the fields in the existing submitter_id index
Attachment #187679 - Flags: review?(mkanat)

Comment 2

14 years ago
Comment on attachment 187679 [details] [diff] [review]
Add bug_id to the fields in the existing submitter_id index


  Great! Looks good, and it tests out correctly on landfill.

>+# 2005-06-29 bugreport@peshkin.net, bug 299156
>+if ($dbh->bz_index_info('attachments', 'attachments_submitter_id_idx') 
>+   && (scalar(@{$dbh->bz_index_info('attachments', 
>+                                    'attachments_submitter_id_idx'
>+                                   )->{FIELDS}}) < 2)
>+      ) {

  Nit: I'd prefer the following spacing:

  if ($dbh
      &&......................('attachments'
		       ....................
			      )

  So that the parens line up and the && is "inside" the if parens.
Attachment #187679 - Flags: review?(mkanat) → review+

Comment 3

14 years ago
(In reply to comment #2)
>   So that the parens line up

  Oh, never mind about that, they do line up. It just doesn't look like it,
because of the font or something.

  Anyhow, this is a simple polish fix that I think is appropriate for a pre-RC
checkin.
Status: NEW → ASSIGNED
Flags: approval?
Target Milestone: --- → Bugzilla 2.20
What are the impacts of the bug and its fix?
Err, ignore that last comment; it was intended for a different bug.  Simple
polish fix; r=myk for check-in during 2.20 freeze.
Flags: approval? → approval+

Comment 6

14 years ago
Could we wait that the two security bugs land before checking this one in? This
one would conflict with one of them and I *really* don't want to update it. :-/
(Assignee)

Comment 7

14 years ago
Sure... add a dependency

Updated

14 years ago
Depends on: 292544

Comment 8

14 years ago
joel, bug 292544 has been checked in...
(Assignee)

Updated

14 years ago
Flags: approval2.20?
Myk appears to have already approved this for 2.20 in a comment, the flag just
didn't exist yet when he did it.
Flags: approval2.20? → approval2.20+
(Assignee)

Comment 10

14 years ago
On HEAD:
Checking in checksetup.pl;
/cvsroot/mozilla/webtools/bugzilla/checksetup.pl,v  <--  checksetup.pl
new revision: 1.415; previous revision: 1.414
done
Checking in Bugzilla/DB/Schema.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/DB/Schema.pm,v  <--  Schema.pm
new revision: 1.33; previous revision: 1.32
done


On 2.20 branch:
Checking in checksetup.pl;
/cvsroot/mozilla/webtools/bugzilla/checksetup.pl,v  <--  checksetup.pl
new revision: 1.412.2.1; previous revision: 1.412
done
Checking in Bugzilla/DB/Schema.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/DB/Schema.pm,v  <--  Schema.pm
new revision: 1.32.2.1; previous revision: 1.32
done

Status: ASSIGNED → RESOLVED
Last Resolved: 14 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.