299156 - Sanitycheck check for submitter ids takes a long time on large sites

Status: RESOLVED FIXED

(Bugzilla :: Bugzilla-General, defect)

Description

[Joel Peshkin]

Easy fix... submitter id index should include bug id.

Comment 1

[Joel Peshkin]

Attachment: Add bug_id to the fields in the existing submitter_id index

Comment 2

[Max Kanat-Alexander]

Comment on attachment 187679 [details] [diff] [review]
Add bug_id to the fields in the existing submitter_id index


  Great! Looks good, and it tests out correctly on landfill.

>+# 2005-06-29 [e-mail], bug 299156
>+if ($dbh->bz_index_info('attachments', 'attachments_submitter_id_idx') 
>+   && (scalar(@{$dbh->bz_index_info('attachments', 
>+                                    'attachments_submitter_id_idx'
>+                                   )->{FIELDS}}) < 2)
>+      ) {

  Nit: I'd prefer the following spacing:

  if ($dbh
      &&......................('attachments'
		       ....................
			      )

  So that the parens line up and the && is "inside" the if parens.

Comment 3

[Max Kanat-Alexander]

(In reply to comment #2)
>   So that the parens line up

  Oh, never mind about that, they do line up. It just doesn't look like it,
because of the font or something.

  Anyhow, this is a simple polish fix that I think is appropriate for a pre-RC
checkin.

Comment 4

[Myk Melez [:myk] [@mykmelez]]

What are the impacts of the bug and its fix?

Comment 5

[Myk Melez [:myk] [@mykmelez]]

Err, ignore that last comment; it was intended for a different bug.  Simple
polish fix; r=myk for check-in during 2.20 freeze.

Comment 6

[Frédéric Buclin]

Could we wait that the two security bugs land before checking this one in? This
one would conflict with one of them and I *really* don't want to update it. :-/

Comment 7

[Joel Peshkin]

Sure... add a dependency

Comment 8

[Frédéric Buclin]

joel, bug 292544 has been checked in...

Comment 9

[Dave Miller [:justdave]]

Myk appears to have already approved this for 2.20 in a comment, the flag just
didn't exist yet when he did it.

Comment 10

[Joel Peshkin]

On HEAD:
Checking in checksetup.pl;
/cvsroot/mozilla/webtools/bugzilla/checksetup.pl,v  <--  checksetup.pl
new revision: 1.415; previous revision: 1.414
done
Checking in Bugzilla/DB/Schema.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/DB/Schema.pm,v  <--  Schema.pm
new revision: 1.33; previous revision: 1.32
done


On 2.20 branch:
Checking in checksetup.pl;
/cvsroot/mozilla/webtools/bugzilla/checksetup.pl,v  <--  checksetup.pl
new revision: 1.412.2.1; previous revision: 1.412
done
Checking in Bugzilla/DB/Schema.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/DB/Schema.pm,v  <--  Schema.pm
new revision: 1.32.2.1; previous revision: 1.32
done