299366 - Reimplement alarm notifications

Status: RESOLVED FIXED

(Calendar :: Sunbird Only, defect)

Description

[Joey Minta]

calAlarmService is currently announcing that alarms are firing, but no one is 
listening.

Comment 1

[Joey Minta]

Attachment: Alarms patch

As said in the code comments, this should ideally be a component, but for me
using initAlarmMonitor() works fine for now.

Note that jar.mn changes have NOT been tested. :-(

Comment 2

[Michiel van Leeuwen (email: mvl+moz@)]

(something went wrong with your patch, some newlines are missing)
I'm not sure about this. I mean, the code to make it a service already is there.
Can't we just copy/move the lightning service?

Comment 3

[Joey Minta]

Yes, most of it can be copied, and I can try to do that once I get building 
working, oris the proper way to replace the following lightningAlarmMonitor.js 
lines with in the calendar code:

109         catman.addCategoryEntry("alarm-service-startup", "lightning",
110                                 "service," + this.myContractID, true, true);
111         catman.addCategoryEntry("alarm-service-shutdown", "lightning",
112                                 "service," + this.myContractID, true, true);

and

127     myContractID: "@mozilla.org/lightning/alarm-monitor;1",

I don't know these naming conventions, etc. :-(

Comment 4

[Michiel van Leeuwen (email: mvl+moz@)]

pav, can we make the service more general, and make the uri of the dialog be
point to something different for calendar vs lighting if we ever want the alarms
to be different?

Comment 5

[Joey Minta]

(In reply to comment #4)
> if we ever want the alarms to be different?

Right now it'd already be better if we could put calendar-alarm-dialog.css in 
skin for calendar/sunbird, so I'll second this.

Comment 6

[Joey Minta]

Attachment: better patch

Done properly as a component.  The component stuff is copied straight from
lightning (with GUID, etc changes). The actual alarm observer has some changes
to help with sunbird's extra options.

No email alarms yet.

Comment 7

[Michiel van Leeuwen (email: mvl+moz@)]

Comment on attachment 188430 [details] [diff] [review]
better patch

r=mvl, except the Makefile.in part. That is not needed (it is obsolete)

Comment 8

[Michiel van Leeuwen (email: mvl+moz@)]

checked in