299391 - Provide API to centralize calls that set persistent cookies

Status: NEW

(Bugzilla :: Bugzilla-General, defect)

Description

[Christian Reis]

Following up from bug 268146, we should provide API to centralize calls that set
persistent cookies. There are a few callsites to consider:

kiko@lozenge:~/devel/bugzilla$ grep -r 2038 *
buglist.cgi:                          -expires => 'Fri, 01-Jan-2038 00:00:00 GMT');
buglist.cgi:                          -expires => 'Fri, 01-Jan-2038 00:00:00 GMT');
Bugzilla/Auth/Login/WWW/CGI.pm:                              -expires => 'Fri,
01-Jan-2038 00:00:00 GMT');
Bugzilla/Auth/Login/WWW/CGI.pm:                              -expires => 'Fri,
01-Jan-2038 00:00:00 GMT');
colchange.cgi:                      -expires => 'Fri, 01-Jan-2038 00:00:00 GMT');
colchange.cgi:                      -expires => 'Fri, 01-Jan-2038 00:00:00 GMT');
post_bug.cgi:                          -expires => "Fri, 01-Jan-2038 00:00:00 GMT");
query.cgi:                              -expires => "Fri, 01-Jan-2038 00:00:00
GMT");
query.cgi:                      -expires => "Fri, 01-Jan-2038 00:00:00 GMT");

One option is having the API be called set_persistent_cookie(). Another option
is making the default in set_cookie() to set this cookie to this date if no
expires is set.