Closed Bug 299590 Opened 14 years ago Closed 14 years ago

nsImapMailFolder.cpp:1529: warning: cast to pointer from integer of different size

Categories

(MailNews Core :: Networking, defect, trivial)

x86
Linux
defect
Not set
trivial

Tracking

(Not tracked)

RESOLVED WONTFIX

People

(Reporter: bastiaan, Assigned: bastiaan)

References

(Blocks 1 open bug, )

Details

Attachments

(1 file)

This can be done more easily..
Attached patch fixSplinter Review
Attachment #188158 - Flags: superreview?(bienvenu)
Attachment #188158 - Flags: review?(bienvenu)
Severity: minor → trivial
Blocks: buildwarning
Comment on attachment 188158 [details] [diff] [review]
fix

the previous code just seems wrong...
Attachment #188158 - Flags: superreview?(bienvenu)
Attachment #188158 - Flags: superreview+
Attachment #188158 - Flags: review?(bienvenu)
Attachment #188158 - Flags: review+
Attachment #188158 - Flags: approval1.8b4?
Comment on attachment 188158 [details] [diff] [review]
fix

actually, I think the code was right before. I need to investigate a little.
Attachment #188158 - Flags: superreview+
Attachment #188158 - Flags: review-
Attachment #188158 - Flags: review+
Attachment #188158 - Flags: approval1.8b4?
Hm. it appears to me (but please correct me if you think I'm wrong) that, given
the way the array is used, my change is wrong, but the old code seems even worse.

It appears to me that FormatStringFromID expects an array of NULL-terminated
unicode strings (in this case, only one such string). So we should use something
like..

PRUnichar tempString = { m_hierarchyDelimiter, '\0' };
const PRUnichar *formatStrings[] =
{
  tempString
};

right?
If you look at the string we're formatting, it contains a %c, meaning it expects
a character, not a string, as one of the var args. I suspect your change would
have broken this code.
Ah, okay. I can't find the string we're formatting, but I'll take your word for it.
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → WONTFIX
Product: Core → MailNews Core
You need to log in before you can comment on or make changes to this bug.