299590 - nsImapMailFolder.cpp:1529: warning: cast to pointer from integer of different size

Status: RESOLVED WONTFIX

(MailNews Core :: Networking, defect)

Description

[Bastiaan Jacques]

This can be done more easily..

Comment 1

[Bastiaan Jacques]

Attachment: fix

Comment 2

[David :Bienvenu]

Comment on attachment 188158 [details] [diff] [review]
fix

the previous code just seems wrong...

Comment 3

[David :Bienvenu]

Comment on attachment 188158 [details] [diff] [review]
fix

actually, I think the code was right before. I need to investigate a little.

Comment 4

[Bastiaan Jacques]

Hm. it appears to me (but please correct me if you think I'm wrong) that, given
the way the array is used, my change is wrong, but the old code seems even worse.

It appears to me that FormatStringFromID expects an array of NULL-terminated
unicode strings (in this case, only one such string). So we should use something
like..

PRUnichar tempString = { m_hierarchyDelimiter, '\0' };
const PRUnichar *formatStrings[] =
{
  tempString
};

right?

Comment 5

[David :Bienvenu]

If you look at the string we're formatting, it contains a %c, meaning it expects
a character, not a string, as one of the var args. I suspect your change would
have broken this code.

Comment 6

[Bastiaan Jacques]

Ah, okay. I can't find the string we're formatting, but I'll take your word for it.