299653 - sanitycheck.cgi should catch missing bugs.creation_ts

Status: RESOLVED FIXED

(Bugzilla :: Bugzilla-General, defect)

Description

[Frédéric Buclin]

Per joel's bug 292544 comment 30, sanitycheck.cgi should catch undefined
bugs.creation_ts, if any.

Keep the security flag till we make bug 292544 public.

Comment 1

[Frédéric Buclin]

2.20rc1 is released; removing the sec flag.

Comment 2

[Frédéric Buclin]

Attachment: patch for tip and 2.20, v1

This patch makes sure no problem arised as per bug 292544 comment 30. This is the only way to fix the problem (if any) except hacking the DB directly as bugs with no creation date are invisible to everyone, including admins.

Comment 3

[Frédéric Buclin]

Attachment: backport for 2.18, v1

Comment 4

[Marc Schumann [:Wurblzap]]

Comment on attachment 205619 [details] [diff] [review]
patch for tip and 2.20, v1

Tested; works.

r=wurblzap with one prerequisite: the status text reads incorrect to me and should probably be "Checking for bugs with no creation date" (note the additional "for"). But then again, I'm no native speaker. Perhaps you can ask a native speaker look at this.

It's a little strange to be offered to view the affected bugs in a bug list -- this list will always be empty, of course. As a nit, the "Checking bugs with no creation date" message could perhaps be made to prepare for this, for example "Checking for bugs which are invisible because they have no creation date". Something less clumsy than this would be even better :)

I'm not convinced yet we want this on 2.18...

Comment 5

[Dave Miller [:justdave]]

bug 292544 got checked in on 2.18 so this should, too.  But I agree with comment 4 that the text needs to be cleaned up.  

Comment 6

[Frédéric Buclin]

tip:

Checking in sanitycheck.cgi;
/cvsroot/mozilla/webtools/bugzilla/sanitycheck.cgi,v  <--  sanitycheck.cgi
new revision: 1.109; previous revision: 1.108
done

2.20:

Checking in sanitycheck.cgi;
/cvsroot/mozilla/webtools/bugzilla/sanitycheck.cgi,v  <--  sanitycheck.cgi
new revision: 1.97.2.4; previous revision: 1.97.2.3
done

2.18.4:

Checking in sanitycheck.cgi;
/cvsroot/mozilla/webtools/bugzilla/sanitycheck.cgi,v  <--  sanitycheck.cgi
new revision: 1.72.2.5; previous revision: 1.72.2.4
done