rebrand default icons (in chrome/icons/default/)

RESOLVED FIXED

Status

SeaMonkey
General
RESOLVED FIXED
13 years ago
13 years ago

People

(Reporter: Robert Kaiser, Assigned: Robert Kaiser)

Tracking

Bug Flags:
blocking-seamonkey1.0a +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 2 obsolete attachments)

(Assignee)

Description

13 years ago
In our SeaMonkey app dir, subdir chrome/icons/default/, we install all window
icons, but also an app icon along with them.

On Windows, that's mozilla.ico (from /xpfe/bootstrap/icons/windows/mozilla.ico)
on Linux, it's default.xpm (from /widget/src/gtk2/default.xpm)

Both those still feature the Mozilla head, we should deliver SeaMonkey icons though.

For Windows, we actually can use a copy of xpfe/bootstrap/mozilla.ico (though we
maybe should rename it to seamonkey.ico as it's shown to the user)
For Linux, creating an xpm version of the win icon is no big problem...
(Assignee)

Comment 1

13 years ago
We should not ship Alpha with those Mozilla-branded icons.
Flags: blocking-seamonkey1.0a+

Comment 2

13 years ago
Add /xpfe/bootstrap/macbuild/Contents/Resources/*.icns to that list of icon
files to be updated, on the Mac side of things.
(Assignee)

Comment 3

13 years ago
(In reply to comment #2)
> Add /xpfe/bootstrap/macbuild/Contents/Resources/*.icns to that list of icon
> files to be updated, on the Mac side of things.

Why that? I thought you already updated the main app icon in there?
Note that I don't plan to change the window icons right now, those don't use the
Mozilla head image and can stay until we got a real logo...
(Assignee)

Updated

13 years ago
Blocks: 285696
No longer depends on: 285696

Comment 4

13 years ago
Sorry, I misunderstood this bug.
(Some of the Mac icons for files to be opened by Seamonkey are just derivations
of the Mozilla M plus some arrow etc., these are found at the location above.)
(Assignee)

Comment 5

13 years ago
Created attachment 188660 [details] [diff] [review]
patch v1: add icons into suite/app and install them

OK, first shot of a patch for that, basically paralleling what Firefox does,
though kept a bit simpler.
Attachment #188660 - Flags: superreview?(neil.parkwaycc.co.uk)
Attachment #188660 - Flags: review?(benjamin)

Updated

13 years ago
Attachment #188660 - Flags: review?(benjamin) → review+

Comment 6

13 years ago
Comment on attachment 188660 [details] [diff] [review]
patch v1: add icons into suite/app and install them

I filed bugs 300129 and 300133 on the fact that GTK1/2 don't play quite as
nicely with default.xpm as they should. But Windows (and possibly OS/2)
actually wants to link with the icon (in splash.rc of all places) to display in
shortcuts etc.
(Assignee)

Comment 7

13 years ago
(In reply to comment #6)
> (From update of attachment 188660 [details] [diff] [review] [edit])
> I filed bugs 300129 and 300133 on the fact that GTK1/2 don't play quite as
> nicely with default.xpm as they should. But Windows (and possibly OS/2)
> actually wants to link with the icon (in splash.rc of all places) to display in
> shortcuts etc.

We currently build the icon files from xpfe/bootstrap into the Win and OS/2 .exe
files, and the ones I'm adding here are actually copies of those at the moment
(not this is now for SeaMonkey placeholder artwork, old Mozilla suite used/uses
two different icon files and looks there). In the future, when we once may build
all the new startup stuff, we should directly use suite/app/ icons for the .exe
files as well.
I think though that we should always install an app icon file in
chrome/icons/default/ even if the .exe contains an icon itself.
(Assignee)

Comment 8

13 years ago
Comment on attachment 188660 [details] [diff] [review]
patch v1: add icons into suite/app and install them

Note that there's a small glitch in the patch that causes a bustage when
testing it:

>+	$(INSTALL) seamonkey.ico $(DIST)/bin/chrome/icons/default

should be
	$(INSTALL) $(srcdir)/seamonkey.ico $(DIST)/bin/chrome/icons/default

Same for the other 4 $(INSTALL) lines: prefix the icon name with $(srcdir)/ if
you're testing that patch, I've fixed that locally.
(Assignee)

Comment 9

13 years ago
Created attachment 189459 [details] [diff] [review]
patch v2: only gtk, placed in branding/icons/gtk

OK, after some talk with Neil, we decided to better keep the icons in
suite/branding/icons/<toolkit>, and do only the gtk variants for now, as
windows (and supposedly OS/2) doesn't have an app icon installed in
chrome/icons, it's built into the executable anyways.
(Assignee)

Updated

13 years ago
Attachment #188660 - Attachment is obsolete: true
Attachment #189459 - Flags: superreview?(neil.parkwaycc.co.uk)
Attachment #189459 - Flags: review?(benjamin)
(Assignee)

Updated

13 years ago
Attachment #188660 - Flags: superreview?(neil.parkwaycc.co.uk)
(Assignee)

Comment 10

13 years ago
Created attachment 189464 [details] [diff] [review]
patch v2.1: add new Makefile to allmakefiles.sh as well

Sorry for the spam, but I realized I should add the new Makefile to
allmakesfiles.sh as well (even though it did work without that here).
All but the first hunk is the same as patch v2.
Attachment #189459 - Attachment is obsolete: true
Attachment #189464 - Flags: superreview?(neil.parkwaycc.co.uk)
Attachment #189464 - Flags: review?(benjamin)
(Assignee)

Updated

13 years ago
Attachment #189459 - Flags: superreview?(neil.parkwaycc.co.uk)
Attachment #189459 - Flags: review?(benjamin)

Updated

13 years ago
Attachment #189464 - Flags: superreview?(neil.parkwaycc.co.uk) → superreview+

Updated

13 years ago
Attachment #189464 - Flags: review?(benjamin) → review+
(Assignee)

Comment 11

13 years ago
Comment on attachment 189464 [details] [diff] [review]
patch v2.1: add new Makefile to allmakefiles.sh as well

requesting approval. This is a strictly SeaMonkey-only change (all files in
suite/ but allmakefiles, which only gets a suite Makefile added)
Attachment #189464 - Flags: approval1.8b4?

Updated

13 years ago
Attachment #189464 - Flags: approval1.8b4? → approval1.8b4+
(Assignee)

Comment 12

13 years ago
Checked in, and it seems we don't need icons in there for other platforms right now.
I filed bug 301505 on gtk1 still shipping mozicon*.xpm in icons/
Status: NEW → RESOLVED
Last Resolved: 13 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.