Need a way for chrome to turn off error pages

RESOLVED FIXED

Status

()

Core
Document Navigation
--
enhancement
RESOLVED FIXED
13 years ago
13 years ago

People

(Reporter: neil@parkwaycc.co.uk, Assigned: neil@parkwaycc.co.uk)

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

13 years ago
Both Composer and Help are confused by error pages:
* Trying to load an unavailable page into Composer loads a broken error page
* Clicking an unavailable link in Help has no effect
So I would like some per-docshell way of turning error pages off.
I guess we could stick some stuff for this on nsIDocShell for now, but
eventually we want to expose this to embeddors too.  Too bad nsIWebBrowserSetup
is frozen.  :(
(Assignee)

Comment 2

13 years ago
Created attachment 188667 [details] [diff] [review]
Proposed patch
Assignee: nobody → neil.parkwaycc.co.uk
Status: NEW → ASSIGNED
(Assignee)

Updated

13 years ago
Attachment #188667 - Flags: superreview?(darin)

Comment 3

13 years ago
Comment on attachment 188667 [details] [diff] [review]
Proposed patch

looks fine to me.  get r= from bz or biesi as well.
Attachment #188667 - Flags: superreview?(darin) → superreview+
(Assignee)

Updated

13 years ago
Attachment #188667 - Flags: review?(cbiesinger)
Comment on attachment 188667 [details] [diff] [review]
Proposed patch

looks ok to me... when (if) docshell observes pref changes, it needs to be
careful not to overwrite explicit setting...

it'd probably be also nice to expose this on an interface that has chances of
ever being frozen...
Attachment #188667 - Flags: review?(cbiesinger) → review+
(Assignee)

Comment 5

13 years ago
We could just get the browser to observe the pref change instead...
(Assignee)

Updated

13 years ago
Attachment #188667 - Flags: approval1.8b3?

Updated

13 years ago
Attachment #188667 - Flags: approval1.8b3? → approval1.8b3+
(Assignee)

Comment 6

13 years ago
Fix checked in.
Status: ASSIGNED → RESOLVED
Last Resolved: 13 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.