Closed Bug 300022 Opened 19 years ago Closed 19 years ago

Need a way for chrome to turn off error pages

Categories

(Core :: DOM: Navigation, enhancement)

Product:
Core
Component:
DOM: Navigation
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: neil, Assigned: neil)

References

Details

Attachments

(1 file)

Proposed patch
3.13 KB, patch
Biesinger
: review+
darin.moz
: superreview+
asa
: approval1.8b3+
Details | Diff | Splinter Review 
Both Composer and Help are confused by error pages:
* Trying to load an unavailable page into Composer loads a broken error page
* Clicking an unavailable link in Help has no effect
So I would like some per-docshell way of turning error pages off.
I guess we could stick some stuff for this on nsIDocShell for now, but
eventually we want to expose this to embeddors too.  Too bad nsIWebBrowserSetup
is frozen.  :(
Attached patch Proposed patch — — Splinter Review 
Assignee: nobody → neil.parkwaycc.co.uk
Status: NEW → ASSIGNED

    
  

        Attachment #188667 -
        Flags: superreview?(darin)

    
    

    
  
Comment on attachment 188667 [details] [diff] [review]
Proposed patch

looks fine to me.  get r= from bz or biesi as well.

        Attachment #188667 -
        Flags: superreview?(darin) → superreview+

    
  

        Attachment #188667 -
        Flags: review?(cbiesinger)

    
    

    
  
Comment on attachment 188667 [details] [diff] [review]
Proposed patch

looks ok to me... when (if) docshell observes pref changes, it needs to be
careful not to overwrite explicit setting...

it'd probably be also nice to expose this on an interface that has chances of
ever being frozen...

        Attachment #188667 -
        Flags: review?(cbiesinger) → review+

    
    

    
  
We could just get the browser to observe the pref change instead...

    
  

        Attachment #188667 -
        Flags: approval1.8b3?

    
  

        Attachment #188667 -
        Flags: approval1.8b3? → approval1.8b3+

    
    

    
  
Fix checked in.
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: