300130 - Schema Loader crashes due to missing NULL check

Status: RESOLVED FIXED

(Core Graveyard :: Web Services, defect)

Description

[Doron Rosenberg (IBM)]

Schema Loader crashes on:

  <xsd:element name="foo" type="bar"/>

if bar is not defined.

Comment 1

[Doron Rosenberg (IBM)]

Attachment: patch

Type may be not set, so make sure it is not null.

Comment 2

[Peter Van der Beken [:peterv]]

Comment on attachment 188705 [details] [diff] [review]
patch

type will always be null there (nsCOMPtr that hasn't been assigned a value).

Comment 3

[Doron Rosenberg (IBM)]

Attachment: oops, this is the right patch

type might never be set, so only use it if it exists.

Comment 4

[Peter Van der Beken [:peterv]]

Comment on attachment 189218 [details] [diff] [review]
oops, this is the right patch

>Index: extensions/webservices/schema/src/nsSchemaComplexType.cpp
>===================================================================

>@@ -133,31 +133,33 @@ nsSchemaComplexType::Resolve(nsIWebServi

>   if (mModelGroup) {
>     rv = mModelGroup->Resolve(aErrorHandler);
>     if (NS_FAILED(rv)) {
>-      nsAutoString modelName;
>-      nsresult rv1 = type->GetName(modelName);
>-      NS_ENSURE_SUCCESS(rv1, rv1);
>-
>-      nsAutoString errorMsg;
>-      errorMsg.AppendLiteral("Failure resolving schema complex type, ");
>-      errorMsg.AppendLiteral("cannot resolve model group \"");
>-      errorMsg.Append(modelName);
>-      errorMsg.AppendLiteral("\"");
>+      if (type) {
>+        nsAutoString modelName;
>+        nsresult rv1 = type->GetName(modelName);

Shouldn't this just use mModelGroup->GetName()?

Comment 5

[Doron Rosenberg (IBM)]

Attachment: indeed, your way is more logical

Comment 6

[Mike Kaply [:mkaply]]

Comment on attachment 189778 [details] [diff] [review]
indeed, your way is more logical

a=mkaply

Comment 7

[Doron Rosenberg (IBM)]

checked in, thanks!