300165 - Print preview disables designmode

Status: RESOLVED WORKSFORME

(Core :: Print Preview, defect)

Description

[Boris Zbarsky [:bzbarsky]]

Print preview usually (but not always) tears down the old presshell and just
creates a new one when you exit print preview.  This disables designmode by
tearing down the presshell the editor was set up for.

Perhaps we should always cache the presshell in print preview (sort of like the
way fastback works)?  We have to do it anyway for pages with plugins,
apparently, so I'd say it's better to have only one codepath...  Failing that,
we should somehow make editor deal with this (possibly with  some outside help)

Comment 1

[Kathleen :Brade]

I don't know much about print preview (since Mac uses a non-XUL solution); can
someone give me some background:
  Is it desirable to have a working editor in print preview?
  Can input/textareas be manipulated?
  Is JS enabled or disabled?

Comment 2

[Hixie (not reading bugmail)]

Nothing dynamic should occur during print preview. Everything in the page should
be dead to user interaction, nothing should animate.

The bug, however, is about things being broken when _leaving_ print preview.

Comment 3

[Boris Zbarsky [:bzbarsky]]

What Ian said.  While in print preview there should be no working editor, no JS,
and no manipulation by the user; this bug is about the fact that when print
preview is exited, the editor that was set up is still busted.

The testcase is at https://bugzilla.mozilla.org/attachment.cgi?id=188068 -- just
enter print preview, then exit it, then try editing the page.

Comment 4

[Johnny Stenback (:jst)]

Print preview is *so* very busted by design in our code that at least long-term,
we should fix it to not use the same window for showing the preview since that's
just *not* safe (JS running in other windows changing the window we're
previewing etc is only one of the problems that can't be solved in a reasonable
way)...

Comment 5

[Jonathan Watt [:jwatt]]

(In reply to Johnny Stenback  (:jst) from comment #4)
> Print preview is *so* very busted by design in our code that at least
> long-term,
> we should fix it to not use the same window for showing the preview

Exactly what we do nowadays. We clone the doc and show the preview in another tab.