300250 - Clipboard functions (cut, copy, paste) don't work

Status: RESOLVED FIXED

(Calendar :: Sunbird Only, defect)

Description

[Joey Minta]

The clipboard functions don't work at all.

Cut/Copy is still using an export function that asks for event.start, etc 
instead of event.startDate.

Paste is still trying to use parseIcalEvents which was replaced by parseIcal.  
However, unlike parseIcalEvents, parseIcal doesn't return an event array.  This 
can be worked around, but it might be worth changing, since clipboard needs to 
alter the events before they are added to the calendar.

One question comes to mind: When pasting multiple events, should they all be 
added to the selected day or should the earliest be added to the selected day, 
and the time difference between the events preserved?  Or give the user the 
option?

Comment 1

[gekacheka]

Re: pasting times of single and multiple events

See patch and comments at bug 199422 comment 17.

Comment 2

[Joey Minta]

FYI on other programs:
Outlook keeps the time difference between events when pasting.

Lotus Notes keeps the times of events, but places them all on the selected day.

Taking this annoying sucker.  It's mostly done in my tree.  Patch tomorrow probably.

Comment 3

[Joey Minta]

Attachment: full patch v1

The whitespacing in the file was pretty bad, so this includes fixes to most of
it as well as getting the clipboard functions back working.

Comment 4

[Joey Minta]

Attachment: patch v1 -w

Same as above but -w to hopefully help with the readability.

Comment 5

[Michiel van Leeuwen (email: mvl+moz@)]

Comment on attachment 192189 [details] [diff] [review]
patch v1 -w

>+    var icssrv = Components.classes["@mozilla.org/calendar/ics-service;1"]
>+                       .getService(Components.interfaces.calIICSService);
Nit: Align the dots. (Here, and in a few other places)

>+                if (item.startDate) 
>+                    date = item.startDate.clone();
>+                if (item.entryDate)
>+                    date = item.entryDate.clone();
>+                else if (item.dueDate)
>+                    date = item.dueDate.clone();

Are you sure the second if shouldn't be else if?
Also, add a newline to seperate this block from the next.

r=mvl with those.

Comment 6

[Joey Minta]

Patch checked in.

Comment 7

[Joey Minta]

*** Bug 278087 has been marked as a duplicate of this bug. ***