300697 - Tools-> Options-> Cache-> Clear Cache Now and Help buttons have the same keyboard shortcut _h_ and thus one doesn't work when using the keyboard shortcut.

Status: RESOLVED DUPLICATE of bug 191642

(Firefox :: Keyboard Navigation, defect)

Description

[Bryan]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b3) Gecko/20050713 Firefox/1.0+
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b3) Gecko/20050713 Firefox/1.0+ ID:2005071315

Tools-> Options-> Cache-> Clear Cache Now and Help buttons have the same
keyboard shortcut _h_ and thus one doesn't work when using the keyboard shortcut.

Reproducible: Always

Steps to Reproduce:
1. Download latest Deer Park build
2. Launch DP :-)
3. Click Tools-> Options-> Cache->
4. Observe that both the Clear Cache Now and Help buttons have the same keyboard
shortcut _h_ and thus one doesn't work when using the keyboard shortcut.

Actual Results:  
Observe that both the Clear Cache Now and Help buttons have the same keyboard
shortcut _h_ and thus one doesn't work when using the keyboard shortcut.

Expected Results:  
The Clear Cache Now and Help buttons should have DIFFERENT keyboard shortcuts
and  that clicking ALT+Keyboard Shortcut would actually work!

Any of the letters in the word "Clear" (Clear Cache Now) are available for use
as a keyboard shortcut in that dialog.

Comment 1

[Steve England [:stevee]]

*** Bug 300698 has been marked as a duplicate of this bug. ***

Comment 2

[u60234]

Actually, the only key available for "Clear Cache Now" is "N". Due to bug
143065, all tab sheets in the Privacy panel must share the same set of accesskeys.

Because of this, the accesskey for "Remember visited pages for the last x days"
is also broken. "R" is taken by "Remove Master Password" on the Password tab.
The "P" for "Remember Password" is also used for "use up to:" on the Cache tab.

Comment 3

[u60234]

Attachment: patch

Use "b" for "Remember Password", "t" for "Use up to:", and "N" for "Clear Cache
Now".

Comment 4

[Bryan]

EEK!!!  A few ppl working on this I see.  I fixed about ten or so accesskey
issues in Tools-> Options last night and forwarded the changes to Gavin.  I
believe he's going to create the diff's tonight and the subsequent patch.

Comment 5

[u60234]

Comment on attachment 189310 [details] [diff] [review]
patch

Oh, feel free then to take this bug if a more comprehensive patch is
forthcoming.

Comment 6

[Bryan]

Attachment: More comprehensive patch to address additional accesskey issues in Tools-> Options

This should be better then what we have now and resolves the bustage from the
landing of the bug to add "Help" buttons to the Options dialogs.

Comment 7

[Bryan]

I've got an even more comprehensive patch coming up in the next day or two! 
I've added about 40 additional accesskeys and fixed those that were "broken".

Comment 8

[:Gavin Sharp [email: [e-mail]]]

This has really turned in to bug 191642, so duping. Bryan, post the new patch in
that bug, please.

*** This bug has been marked as a duplicate of 191642 ***