Closed
Bug 300743
Opened 19 years ago
Closed 19 years ago
Query help tooltips appear at wrong position
Categories
(Bugzilla :: Query/Bug List, defect)
Tracking
()
RESOLVED
FIXED
Bugzilla 2.20
People
(Reporter: gerv, Assigned: gerv)
Details
Attachments
(1 file)
The query page help tooltips are appearing at the wrong position. This is because we don't add "px" to the values we are setting using script. Gerv
Assignee | ||
Comment 1•19 years ago
|
||
Here's the fix. Gerv
Updated•19 years ago
|
Attachment #189281 -
Flags: review+
Comment 2•19 years ago
|
||
As Luis pointed out, this should probably block 2.20.
Flags: blocking2.20+
Hardware: PC → All
Target Milestone: --- → Bugzilla 2.20
Updated•19 years ago
|
Whiteboard: [patch awaiting review]
Comment 3•19 years ago
|
||
Comment on attachment 189281 [details] [diff] [review] Patch v.1 Tested on both trunk and 2.20 branch. This certainly fixes the help positioning issue on Firefox (help is not supported on IE or Opera). Fwiw, looks good to me.
Attachment #189281 -
Flags: review+
Assignee | ||
Updated•19 years ago
|
Flags: approval2.20?
Updated•19 years ago
|
Attachment #189281 -
Flags: review?(myk) → review+
Comment 4•19 years ago
|
||
In my browser, the tooltips aren't appearing at all because of this bug. The JavaScript console says "Error: Error in parsing value for property '[top|left]'. Declaration dropped."
Flags: approval2.20?
Flags: approval2.20+
Flags: approval+
Updated•19 years ago
|
Whiteboard: [patch awaiting review]
Assignee | ||
Comment 5•19 years ago
|
||
Fixed. Checking in template/en/default/global/help-header.html.tmpl; /cvsroot/mozilla/webtools/bugzilla/template/en/default/global/help-header.html.tmpl,v <-- help-header.html.tmpl new revision: 1.5; previous revision: 1.4 done Gerv
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Comment 6•19 years ago
|
||
gerv, you forgot to land it on the 2.20 branch too. 2.20rc2: Checking in template/en/default/global/help-header.html.tmpl; /cvsroot/mozilla/webtools/bugzilla/template/en/default/global/help-header.html.tmpl,v <-- help-header.html.tmpl new revision: 1.4.4.1; previous revision: 1.4 done
You need to log in
before you can comment on or make changes to this bug.
Description
•