300743 - Query help tooltips appear at wrong position

Status: RESOLVED FIXED

(Bugzilla :: Query/Bug List, defect)

Description

[Gervase Markham [:gerv]]

The query page help tooltips are appearing at the wrong position. This is
because we don't add "px" to the values we are setting using script.

Gerv

Comment 1

[Gervase Markham [:gerv]]

Attachment: Patch v.1

Here's the fix.

Gerv

Comment 2

[Max Kanat-Alexander]

As Luis pointed out, this should probably block 2.20.

Comment 3

[Teemu Mannermaa (:wicked)]

Comment on attachment 189281 [details] [diff] [review]
Patch v.1

Tested on both trunk and 2.20 branch. This certainly fixes the help positioning
issue on Firefox (help is not supported on IE or Opera). Fwiw, looks good to
me.

Comment 4

[Myk Melez [:myk] [@mykmelez]]

In my browser, the tooltips aren't appearing at all because of this bug.  The
JavaScript console says "Error: Error in parsing value for property
'[top|left]'.  Declaration dropped."

Comment 5

[Gervase Markham [:gerv]]

Fixed.

Checking in template/en/default/global/help-header.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/global/help-header.html.tmpl,v
 <--  help-header.html.tmpl
new revision: 1.5; previous revision: 1.4
done

Gerv

Comment 6

[Frédéric Buclin]

gerv, you forgot to land it on the 2.20 branch too.

2.20rc2:

Checking in template/en/default/global/help-header.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/global/help-header.html.tmpl,v
 <--  help-header.html.tmpl
new revision: 1.4.4.1; previous revision: 1.4
done