Closed
Bug 300895
Opened 20 years ago
Closed 20 years ago
EM: "will be installed the next time you restart Firefox" needs grammar check
Categories
(Toolkit :: Add-ons Manager, defect, P3)
Toolkit
Add-ons Manager
Tracking
()
RESOLVED
FIXED
mozilla1.8final
People
(Reporter: u88484, Assigned: tmeader)
References
Details
(Whiteboard: [affects l10n])
Attachments
(3 files)
2.74 KB,
image/png
|
Details | |
2.05 KB,
patch
|
mconnor
:
review-
|
Details | Diff | Splinter Review |
2.05 KB,
patch
|
mconnor
:
review+
mconnor
:
approval1.8b4+
|
Details | Diff | Splinter Review |
In the extension and maybe theme manager when you install an extension you get a
message telling you that "extension will be installed the next time you restart
Firefox" just does not sound right because of 'next time' and 'restart'
Expected: Change to either
'extension will be installed the next time you start firefox'
or
'extension will be installed after you restart firefox'
I'm leaning more towards the second suggestion
Updated•20 years ago
|
Flags: blocking-aviary1.1?
Comment 2•20 years ago
|
||
This string (in installed/removed/enabled/disabled forms) serves two purposes:
1. Feedback for completion of an install operation.
2. Status of the extension.
In all cases, changes only take effect when users restart the browser. I agree
that "next time you restart" is awkward :)
I'd be happy with either Kurt's suggestion:
"myExtension will be installed after you restart Firefox"
($extension_name will be $action after you restart $product_name)
Or the slightly-more accurate:
"myExtension will be installed the next time Firefox starts"
($extension_name will be $action the next time $product_name starts)
Comment 3•20 years ago
|
||
dria's refinement:
"myExtension will be installed when Firefox is restarted"
($extension_name will be $action when $product_name is $action)
(As a follow-up, I began to wonder if we really need an $action of "installed".
The XPI is installed at this point, just not enabled. I think it would be more
accurate to just have "enabled/disabled/uninstalled" as values for $action, and
newly installed extensions start as: "myExtension will be enabled when Firefox
is restarted")
![]() |
||
Comment 4•20 years ago
|
||
(In reply to comment #3)
> (As a follow-up, I began to wonder if we really need an $action of "installed".
> The XPI is installed at this point, just not enabled. I think it would be more
> accurate to just have "enabled/disabled/uninstalled" as values for $action, and
> newly installed extensions start as: "myExtension will be enabled when Firefox
> is restarted")
Not that it matters all that much for this type of user notification but it
isn't installed at this point. During the restart it is installed and at that
point it may also fail to install.
This bug might block Bug# 300860 depending on if this bug is accepted to block
1.84 or 1.1 since it affects l10n
Flags: blocking-aviary1.1?
Comment 6•20 years ago
|
||
Its a string change, we change it for b4 or we don't change it.
Flags: blocking1.8b4?
Flags: blocking1.8b4+
Flags: blocking-aviary1.1?
Flags: blocking-aviary1.1-
Updated•20 years ago
|
Blocks: branching1.8
Assignee | ||
Comment 7•20 years ago
|
||
Will this do? Still within the deadline?
I went ahead and used the seemingly preferred wording with all four messages.
If they require seperate bugs, let me know and I'll attach a patch for just the
phrase the bug is about.
Attachment #189843 -
Flags: review?(mconnor)
Updated•20 years ago
|
Whiteboard: [affects l10n] → [affects l10n] [has patch, needs review? (mconnor)]
Comment 8•20 years ago
|
||
Comment on attachment 189843 [details] [diff] [review]
reword the restart text per the suggestions.
I think we want to go with dria's refinement, see comment 3
Attachment #189843 -
Flags: review?(mconnor) → review-
Assignee | ||
Comment 9•20 years ago
|
||
Using preferred wording.
Attachment #190440 -
Flags: review?(mconnor)
Updated•20 years ago
|
Attachment #190440 -
Flags: review?(mconnor)
Attachment #190440 -
Flags: review+
Attachment #190440 -
Flags: approval1.8b4+
![]() |
||
Comment 10•20 years ago
|
||
(In reply to comment #8)
> (From update of attachment 189843 [details] [diff] [review] [edit])
> I think we want to go with dria's refinement, see comment 3
Keep in mind that there are other strings along the lines of this item could not
be installed when an installation fails during startup
Assignee | ||
Comment 11•20 years ago
|
||
Any chance someone can get this checked in for me now? Thanks in advance.
Updated•20 years ago
|
Assignee: nobody → tmeader
Priority: -- → P3
Target Milestone: --- → Firefox1.1
Comment 12•20 years ago
|
||
Checking in extensions.properties;
/cvsroot/mozilla/toolkit/locales/en-US/chrome/mozapps/extensions/extensions.properties,v
<-- extensions.properties
new revision: 1.18; previous revision: 1.17
done
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
Updated•20 years ago
|
Whiteboard: [affects l10n] [has patch, needs review? (mconnor)] → [affects l10n]
What ever happened to preferring the active voice over the passive?
Comment 14•20 years ago
|
||
Yeah, I wondered a little about that, too. The passive voice exists specifically
to allow emphasis on the object being acted upon (as opposed to on the action
itself) which makes it particularly effective for post-task status messages, and
I think that's the case we're running into here.
While normally I agree that functions and messages in dialogs to users about
what must be done should be active voice, in these cases, the user action
(installing an extension, or pressing "enable"/"disable") is complete, and the
message is an indication of when their action will be completed. Remember that
these strings appear in the EM as status indicators:
ex:
XXXX ForecastFox 1.1
XXXX ForecastFox will be installed when Firefox is restarted.
XXXX All-in-One Gestures 2.0
XXXX All-in-ONE Gestures will be disabled when Firefox is restarted.
XXXX Talkbalk 1.0
XXXX Provides feedback to the Mozilla Organization
as opposed to:
XXXX ForecastFox 1.1
XXXX Restart Firefox to complete installation of ForecastFox
XXXX All-in-One Gestures 2.0
XXXX Restart Firefox to disable All-in-One Gestures.
XXXX Talkbalk 1.0
XXXX Provides feedback to the Mozilla Organization
Hm. Now that I've written them out, they don't look so bad. :) Lemme get dria to
tell me how big a deal this is. :)
Comment 15•20 years ago
|
||
After we branch we should probably take the time to go through and do a copyedit
of all the strings in all our apps. I can't imagine this is an isolated case.
Updated•17 years ago
|
Product: Firefox → Toolkit
You need to log in
before you can comment on or make changes to this bug.
Description
•