300895 - EM: "will be installed the next time you restart Firefox" needs grammar check

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, defect, P3)

Description

[u88484]

In the extension and maybe theme manager when you install an extension you get a
message telling you that "extension will be installed the next time you restart
Firefox" just does not sound right because of 'next time' and 'restart'

Expected: Change to either
'extension will be installed the next time you start firefox' 
or 
'extension will be installed after you restart firefox'

I'm leaning more towards the second suggestion

Comment 1

[u88484]

Attachment: example

Comment 2

[Mike Beltzner [:beltzner, not reading bugmail]]

This string (in installed/removed/enabled/disabled forms) serves two purposes:

1. Feedback for completion of an install operation.
2. Status of the extension.

In all cases, changes only take effect when users restart the browser. I agree
that "next time you restart" is awkward :)

I'd be happy with either Kurt's suggestion:
"myExtension will be installed after you restart Firefox"
($extension_name will be $action after you restart $product_name)

Or the slightly-more accurate:
"myExtension will be installed the next time Firefox starts"
($extension_name will be $action the next time $product_name starts)

Comment 3

[Mike Beltzner [:beltzner, not reading bugmail]]

dria's refinement:

"myExtension will be installed when Firefox is restarted"
($extension_name will be $action when $product_name is $action)

(As a follow-up, I began to wonder if we really need an $action of "installed".
The XPI is installed at this point, just not enabled. I think it would be more
accurate to just have "enabled/disabled/uninstalled" as values for $action, and
newly installed extensions start as: "myExtension will be enabled when Firefox
is restarted")

Comment 4

[Robert Strong (they/them - no direct email)]

(In reply to comment #3)
> (As a follow-up, I began to wonder if we really need an $action of "installed".
> The XPI is installed at this point, just not enabled. I think it would be more
> accurate to just have "enabled/disabled/uninstalled" as values for $action, and
> newly installed extensions start as: "myExtension will be enabled when Firefox
> is restarted")
Not that it matters all that much for this type of user notification but it
isn't installed at this point. During the restart it is installed and at that
point it may also fail to install.

Comment 5

[u88484]

This bug might block Bug# 300860 depending on if this bug is accepted to block
1.84 or 1.1 since it affects l10n

Comment 6

[Mike Connor [:mconnor]]

Its a string change, we change it for b4 or we don't change it.

Comment 7

[Tim Meader]

Attachment: reword the restart text per the suggestions.

Will this do? Still within the deadline?

I went ahead and used the seemingly preferred wording with all four messages.
If they require seperate bugs, let me know and I'll attach a patch for just the
phrase the bug is about.

Comment 8

[Mike Connor [:mconnor]]

Comment on attachment 189843 [details] [diff] [review]
reword the restart text per the suggestions.

I think we want to go with dria's refinement, see comment 3

Comment 9

[Tim Meader]

Attachment: Second shot at the patch.

Using preferred wording.

Comment 10

[Robert Strong (they/them - no direct email)]

(In reply to comment #8)
> (From update of attachment 189843 [details] [diff] [review] [edit])
> I think we want to go with dria's refinement, see comment 3
Keep in mind that there are other strings along the lines of this item could not
be installed when an installation fails during startup

Comment 11

[Tim Meader]

Any chance someone can get this checked in for me now? Thanks in advance.

Comment 12

[:Gavin Sharp [email: [e-mail]]]

Checking in extensions.properties;
/cvsroot/mozilla/toolkit/locales/en-US/chrome/mozapps/extensions/extensions.properties,v
 <--  extensions.properties
new revision: 1.18; previous revision: 1.17
done

Comment 13

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

What ever happened to preferring the active voice over the passive?

Comment 14

[Mike Beltzner [:beltzner, not reading bugmail]]

Yeah, I wondered a little about that, too. The passive voice exists specifically
to allow emphasis on the object being acted upon (as opposed to on the action
itself) which makes it particularly effective for post-task status messages, and
I think that's the case we're running into here.

While normally I agree that functions and messages in dialogs to users about
what must be done should be active voice, in these cases, the user action
(installing an extension, or pressing "enable"/"disable") is complete, and the
message is an indication of when their action will be completed. Remember that
these strings appear in the EM as status indicators:

ex:

 XXXX   ForecastFox 1.1
 XXXX   ForecastFox will be installed when Firefox is restarted.

 XXXX   All-in-One Gestures 2.0
 XXXX   All-in-ONE Gestures will be disabled when Firefox is restarted.

 XXXX   Talkbalk 1.0
 XXXX   Provides feedback to the Mozilla Organization 

as opposed to:

 XXXX   ForecastFox 1.1
 XXXX   Restart Firefox to complete installation of ForecastFox

 XXXX   All-in-One Gestures 2.0
 XXXX   Restart Firefox to disable All-in-One Gestures.

 XXXX   Talkbalk 1.0
 XXXX   Provides feedback to the Mozilla Organization 

Hm. Now that I've written them out, they don't look so bad. :) Lemme get dria to
tell me how big a deal this is. :)

Comment 15

[Deb Richardson [:dria] (plz NEEDINFO)]

After we branch we should probably take the time to go through and do a copyedit
of all the strings in all our apps.  I can't imagine this is an isolated case.