301039 - Top border threedhighlight one pixel too thick as well the as "click-down" menu (all, errors, warnings, etc.) not centered.

Status: RESOLVED FIXED

(Toolkit Graveyard :: Error Console, defect)

Description

[Bryan]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b4) Gecko/20050716 Firefox/1.0+
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b4) Gecko/20050716 Firefox/1.0+ ID:2005071608

Top border threedhighlight one pixel too thick as well the as "click-down" menus
(all, errors, warnings, messages, clear and evaluate) not centered.  The Help
Viewer also suffers from the Top border threedhighlight being one pixel too thick.

Reproducible: Always

Steps to Reproduce:
1. Download latest build (Deer Park)
2. Launch Deer Park
3. Click Tools-> JavaScript Console and or Help-> Help Contents
4. Observe the border above the "click-down" menus (all, errors, warnings,
messages, clear) is one pixel too thick as well as the "click-down" menus (all,
errors, warnings, messages, clear and evaluate) are not centered.  Observe in
the Help Contents that the border above the toolbar menu is one pixel too thick.
Actual Results:  
Observe the border above the "click-down" menus (all, errors, warnings,
messages, clear) is one pixel too thick as well as the "click-down" menus (all,
errors, warnings, messages, clear and evaluate) are not centered.  Observe in
the Help Contents that the border above the toolbar menu is one pixel too thick.

Expected Results:  
All highlight borders BELOW the title bar should MATCH the highlight border
below the title bar in the Firefox (Deer Park) main window as shown in the
attachment.  This also would apply to any extensions that display full windows
that are included in the firefox distribution (DOM Inspector, which is fine
BTW).  Only the JavaScript Console and the Help Viewer exhibit this issue.

Comment 1

[Bryan]

Attachment: Attachment showing the issues described in this BUG.

Attachment showing the issues described in this BUG highlighted in red.

Comment 2

[Bryan]

I forgot to mention that this only pertains to the default FF theme.

Comment 3

[Bryan]

Attachment: Polishes JavaScript Console and Help Viewer bringing them inline with 253661...

Polishes JavaScript Console and Help Viewer bringing them inline with 253661 in
terms of border/border highlight and menubar spacing / centering of text...

Comment 4

[Kevin Gerich]

Comment on attachment 192709 [details] [diff] [review]
Polishes JavaScript Console and Help Viewer bringing them inline with 253661...

thanks for the ping. please excuse the delay

this looks fine on Windows Classic. At some point we should probably totally
remove the top highlight on the first menubar/toolbar in all windows just like
Windows Classic does.

Comment 5

[:Gavin Sharp [email: [e-mail]]]

Trunk:
mozilla/toolkit/themes/winstripe/global/toolbar.css; new revision: 1.8;
mozilla/toolkit/themes/winstripe/global/console/console.css; new revision: 1.7;

Comment 6

[Bryan]

I discovered that I missed the evaluate button in the JCon and have modified the
code to address this issue:

#ToolbarMode .toolbarbutton-text {
  -moz-padding-start: 0px;
  -moz-padding-end: 5px;
}

BECOMES:

.toolbarbutton-text {
  -moz-padding-start: 0px;
  -moz-padding-end: 5px;
}

Gavin said there was no need for a new patch and that he would fix this on the
trunk as well as the patch that is attached himself.

~B

Comment 7

[Bryan]

Attachment: Slight improvement to code that fixes the evaluate button in the JCon I missed previously...

Code cleanup that fixes the "Evaluate" button I missed previously.

Comment 8

[:Gavin Sharp [email: [e-mail]]]

Checked in the correction on the trunk.

Comment 9

[:Gavin Sharp [email: [e-mail]]]

mozilla/toolkit/themes/winstripe/global/toolbar.css; new revision: 1.7.2.1;
mozilla/toolkit/themes/winstripe/global/console/console.css; new revision: 1.6.8.1;

Comment 10

[Kevin Pilasky]

(In reply to comment #4)
> this looks fine on Windows Classic. At some point we should probably totally
> remove the top highlight on the first menubar/toolbar in all windows just like
> Windows Classic does.

Can this be done before 1.5 Final?

Comment 11

[Bryan]

Attachment: Address comment 10...

(In reply to comment #4)
> this looks fine on Windows Classic. At some point we should probably totally
> remove the top highlight on the first menubar/toolbar in all windows just
like
> Windows Classic does.
>
> Can this be done before 1.5 Final?

This was added intentionally as part of bug 253661.  I personally believe it
should stay as our goal was to replicate IE in terms of toolbar and menu
spacing.

~B

Comment 12

[Ben Goodger (use ben at mozilla dot org for email)]

I had to remove the toolbar.css part of this patch since it added an unnecessary
groove at the top of every window. I did this on the branch and the trunk. Sorry
Gavin!