301082 - xpcom-shutdown is too late to destroy cached compose windows

Status: RESOLVED FIXED

(MailNews Core :: Composition, defect)

Description

[Andrew Schultz]

As mentioned in  bug 137698, if cached composition window is enabled on linux,
there are gtk errors when exiting:

(Gecko:19985): Gtk-CRITICAL **: gtk_widget_destroy: assertion `GTK_IS_WIDGET
(widget)' failed
(Gecko:19985): Gtk-CRITICAL **: gtk_main_quit: assertion `main_loops != NULL' failed

nsAppStartup::Quit looks for other windows (via nsIWindowMediator) and attempts
to close them, but it doesn't see the cached compose window.

Later, when nsMsgComposeService gets shut down, it closes its cached window,
which triggers another call to nsAppStartup::Quit.  Things go south from there.
I'll attach a stack for the last call to nsAppStartup::Quit

Comment 1

[Andrew Schultz]

Attachment: stacktrace

this is the stacktrace during the call to nsAppStartup::Quit related to cached
window compose

Comment 2

[Andrew Schultz]

CTho got the same stack as attachment 189583 [details] on windows, so the fact that we try
to shut down the app twice is probably cross-platform.  Windows just doesn't
complain about it.

Comment 3

[[e-mail]]

Attachment: Proposed patch

Comment 4

[David :Bienvenu]

Comment on attachment 189633 [details] [diff] [review]
Proposed patch

do we get the quit-application notification if the app is closed because the
last open window is closed? sr=bienvenu, as long as you confirm that. I have a
vague recollection of that being a problem in the past.

Comment 5

[[e-mail]]

Comment on attachment 189633 [details] [diff] [review]
Proposed patch

biesi remembered that issue too, but I was able to persuade him that
eConsiderQuit got quickly upgraded to eForceQuit if no windows are open.

Comment 6

[[e-mail]]

Fix checked in.