301183 - Winstripe: land replacement warning icons

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Kevin Gerich]

I did some work on the warning icons to make them more in line with the latest
Winstripe highlighting and shadows. I'm posting this bug because I need
permission to land.

These icons are
chrome://global/skin/icons/Error.png
chrome://global/skin/icons/Question.png
chrome://global/skin/icons/Warning.png

you can see the new icons here:
http://kmgerich.com/archive/images/replacement-warning.png

Comment 1

[Kevin Gerich]

Attachment: new error icons

Comment 2

[Kevin Gerich]

checked in. thanks mconnor

Comment 3

[:deanis74]

Microsoft recommends against using the question mark icon for message boxes.

http://msdn.microsoft.com/library/default.asp?url=/library/en-us/dnwue/html/ch09f.asp

Re-opening for consideration of changing this back to an exclamation mark, to
keep in line with Windows standards.

Comment 4

[Ian Macfarlane]

From that page:

"The system also includes a question mark message symbol, as shown in Figure
9.19. This message symbol was used in earlier versions of Windows for cautionary
messages that were phrased as a question.

Inappropriate message symbol

Figure 9.19 Inappropriate message symbol

However, the question mark message icon is no longer recommended, because it
does not clearly represent a specific type of message and because the phrasing
of a message as a question could apply to any message type. In addition, users
can confuse the message symbol question mark with Help information. Therefore,
do not use this question mark message symbol in your message boxes. The system
continues to support its inclusion only for backward compatibility."


I agree that keeping in line with the windows icons is probably a good idea.

Comment 5

[Sean Hayward]

Also in the Microsoft examples the tail of the bubble points to the right (where
the text and command buttons are), whereas the tail of the current Question.png
bubble is pointed to the left (where the outer frame of the error dialog is).

    ____        ____
   /    \      /    \
   | ?  |      | i  |
   \_  _/      \_  _/
    /_/          \_\
  Current        New

Very minute, just though while its reopened.

Comment 6

[:Gavin Sharp [email: [e-mail]]]

(In reply to comment #3)
> Re-opening for consideration of changing this back to an exclamation mark, to
> keep in line with Windows standards.

Re-opening fixed bugs for reasons other than "incomplete fix" and "patch needs to be backed out" is not a good idea, a new bug always works better. In any case, we no longer use these icons anyways, so re-resolving.