Closed Bug 301416 Opened 18 years ago Closed 18 years ago
Form doesn't show submit button: regression from 1
.0 .6 to DPalpha2
318 bytes, text/html
315 bytes, text/html
1.73 KB, patch
|Details | Diff | Splinter Review|
Build ID: FF Deer Park Alpha 2, 20050712 on WinXP. Steps to reproduce: 1. Load testcase with DPa2, no submit button shows up, 2. Load testcase with FF 1.0.6 or IE6, submit button shows up. If I remove the <p>, the <textarea> or the <a> tag, the submit button shows up in DPa2.
This regressed between 2005-06-01-07 and 2005-06-02-07. http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=all&branch=HEAD&branchtype=match&dir=&file=&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=explicit&mindate=2005-06-01+07%3A00&maxdate=2005-06-02+07%3A00&cvsroot=%2Fcvsroot This seems to be an HTML parsing issue. unfortunately, the regression window contains quite a few parser patches.
Assignee: nobody → parser
Component: General → HTML: Parser
Product: Firefox → Core
QA Contact: general → mrbkap
Version: unspecified → Trunk
Camino 0.9a2 is also (logically) affected.
OS: Windows XP → All
Taking, this looks like another bug resulting from the move away from skipped content.
Assignee: parser → mrbkap
I'm not entirely sure why the <p> was needed here, but this patch is correct. The problem is that the <a> is being closed by the <p> and reopened inside the <textarea>, so we were ignoring the <textarea>'s end tag and putting the rest of the document into the textarea. With this patch, we don't allow residual styles to be opened inside the textarea and things are happy.
Comment on attachment 189938 [details] [diff] [review] patch v1 r+sr=jst
Comment on attachment 189938 [details] [diff] [review] patch v1 This patch is very safe and prevents a silly regression where textareas would eat up the rest of the page if there were any residual style tags (such as <a>) on the residual style stack.
Attachment #189938 - Flags: approval1.8b4?
For the record: the <p> is necessary because <a> can contain <textarea>, so it wasn't getting put on the residual style stack. I suspect if there was a space or text before the <textarea>, this problem would have been masked. So the reduced testcase is: <a><p><textarea></textarea>hi
Attachment #189938 - Flags: approval1.8b4? → approval1.8b4+
Fix checked in. Thanks for finding this.
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.8beta4
You need to log in before you can comment on or make changes to this bug.