301587 - Invalid iconURI in install.rdf is not handled very gracefully

Status: VERIFIED WORKSFORME

(Toolkit :: Add-ons Manager, defect)

Description

[Mike Kaply [:mkaply]]

I had a bad URI for my icon in my install.rdf, so my extension didn't work. The
error in the JS console was:

ExtensionManager:_finishOperations - failure, catching exception...
[Exception... "Component returned failure code: 0x804b000a
[nsIIOService.newURI]"  nsresult: "0x804b000a (<unknown>)"  location: "JS frame
:: file:///C:/deerpark/firefox/components/nsExtensionManager.js :: newURI ::
line 543"  data: no]

Per bsmedberg, opening up this bug to see if we can detect this and put a more
graceful error message out.

Comment 1

[Robert Strong (they/them - no direct email)]

What behavior do you think is appropriate? I'd prefer to not make the EM provide debug info for people developing extensions to avoid the EM getting even more ugly. What I'd like to see is an extension developer kit that would provide this type of functionality instead.

Comment 2

[Mike Kaply [:mkaply]]

I just don't think it should be a failure. Not having a valid icon shouldn't be a reason that the extension fails...

Comment 3

[Robert Strong (they/them - no direct email)]

On the other hand the extension developer might not notice it is not shown if they use an invalid uri for iconURL if the behavior were changed... then again we don't verify it actually exists in chrome which will also prevent it from being shown if it doesn't exist. I could go either way in regards to this behavior though I think it is probably more appropriate to not install an extension that has invalid data per the install.rdf spec so it is immediately apparent to the extension author that their data is incorrect.

Comment 4

[Mike Kaply [:mkaply]]

Then can we do something better on the console? Because the error is newURI, you have no callstack to figure out why it happened...

Comment 5

[Robert Strong (they/them - no direct email)]

Sure, I've been planning on fixing / beefing up the error msgs for install failures.

Comment 6

[Dave Townsend [:mossop]]

We never actually call newURI for icons in the new extension manager so I believe that this is fixed.

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+2]]

If an invalid iconURL is specified, we don't show any icon right now (bug 576920) but the extension will still work. Marking as verified (we don't have a bug# so moving it to WFM).