301621 - Expose elements with onclick from addEventListener()

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[Aaron Leventhal]

We now expose elements with onclick handlers added declaratively via an onclick
attribute, but we do not yet expose elements whose onclick was put there via
addEventListener() in a script.

We should expose those as well.

Comment 1

[Aaron Leventhal]

Attachment: Testcase -- 2nd onclick is the one using addEventListener()

Comment 2

[Aaron Leventhal]

Attachment: Testcase -- 2nd onclick is the one using addEventListener()

Comment 3

[Aaron Leventhal]

Attachment: Testcase -- 2nd onclick is the one using addEventListener()

Comment 4

[Aaron Leventhal]

Attachment: WIP -- need to test with patch from bug 379763

Comment 5

[Aaron Leventhal]

Attachment: Use new nsIEventListenerManager::HasListenersFor() API instead of checking onclick attibute

Comment 6

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 263816 [details] [diff] [review]
Use new nsIEventListenerManager::HasListenersFor() API instead of checking onclick attibute


>+
>+PRBool nsAccessibilityUtils::HasListener(nsIContent *aContent, const nsAString& aEventType)
>+{
>+  nsCOMPtr<nsPIDOMEventTarget> eventTarget(do_QueryInterface(aContent));
>+  if (!eventTarget) {
>+    return PR_FALSE;
>+  }

nsIContent is nsPIDOMEventTarget so no need to QI. (Not sure if you need null check still)

Comment 7

[Aaron Leventhal]

Checked in with QI removal. Thanks for the tip.

Comment 8

[Aaron Leventhal]

This doesn't work for <li> elements with an onclick.

Comment 9

[Aaron Leventhal]

Attachment: Allow <li> to be linkable, so that click event handlers affect actions etc.

Also removes unnecessary line that clears focusable state on list. The focusable state is now handled correctly in nsAccessible::GetState(), and technically anything can be focusable now, because of tabindex.

Comment 10

[Aaron Leventhal]

Tim mentioned that on a site like CNN he is seeing far more onclicks in the virtual buffer than he does with IE and a screen reader.