301837 - NaN appears when entering a letter and/or symbol in the history "days" box

Status: RESOLVED FIXED

(Firefox :: Settings UI, defect)

Description

[Dan Fischbach]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b4) Gecko/20050723 Firefox/1.0+
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b4) Gecko/20050723 Firefox/1.0+

See summary above and steps below

Reproducible: Always

Steps to Reproduce:
1. Open to DPa2
2. Go to Tools -> Options -> Privacy tab -> History
3. Click on the history days box in front of the number, so the caret is here:
   ---> |9
4. Enter a letter or symbol now
5. See NaN

***NOTE: When the caret is here ---> 9| and you eneter a letter, it appears but
quickly disappears.  When you have a number like, say, 95, and your caret is
here ---> 9|5, and you enter a letter, this gets rid of the 5, and leaves it
like this: 9|***

Actual Results:  
Showed Nan in the box

Expected Results:  
Disregarded the letter/symbol input

Using: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b4) Gecko/20050723
Firefox/1.0+ ID:2005072306
Zip build

Comment 1

[Adam Guthrie]

*** Bug 301838 has been marked as a duplicate of this bug. ***

Comment 2

[Dan Fischbach]

This is not a dupe as the summaries are different.  I was originally thinking of
grouping them together.

Comment 3

[Jo Hermans]

both seem to be the same bug 299580, but that should been fixed 2 weeks ago

Comment 4

[Aaron Slunt]

Attachment: patch

This simply checks if the inputted value will spit out an NaN, and if so, 0 is
returned. Else, the input is returned.

Comment 5

[Mike Connor [:mconnor]]

Comment on attachment 190281 [details] [diff] [review]
patch

ok, I'll live with the hack in privacy.js, but only because the whole function
is a hack

Comment 6

[:Gavin Sharp [email: [e-mail]]]

Checking in browser/components/preferences/privacy.js;
/cvsroot/mozilla/browser/components/preferences/privacy.js,v  <--  privacy.js
new revision: 1.9; previous revision: 1.8
done
Checking in toolkit/content/widgets/preferences.xml;
/cvsroot/mozilla/toolkit/content/widgets/preferences.xml,v  <--  preferences.xml
new revision: 1.26; previous revision: 1.25
done

Comment 7

[Dan Fischbach]

Isn't 301838 a valid issue, or do the history "days" box and the cache "amount"
box share this same code?

Comment 8

[Aaron Slunt]

(In reply to comment #7)
> Isn't 301838 a valid issue, or do the history "days" box and the cache "amount"
> box share this same code?

The patch covered for both issues.

Comment 9

[Aaron Slunt]

Attachment: include declaration for intValue

Somehow I managed to miss declaring intValue in preferences.xml. It didn't
affect the bug, so I'm leaving this as resolved->fixed, but it does spit out a
warning in the js console. This will take care of that.

Comment 10

[:Gavin Sharp [email: [e-mail]]]

Checked in followup patch.

Checking in preferences.xml;
/cvsroot/mozilla/toolkit/content/widgets/preferences.xml,v  <--  preferences.xml
new revision: 1.27; previous revision: 1.26
done