Closed
Bug 301842
Opened 21 years ago
Closed 20 years ago
chrome errors from reporter locale moving
Categories
(SeaMonkey :: Installer, defect)
SeaMonkey
Installer
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: ajschult784, Assigned: ajschult784)
Details
Attachments
(2 files)
|
6.49 KB,
patch
|
benjamin
:
review+
benjamin
:
approval1.8b4+
|
Details | Diff | Splinter Review |
|
15.09 KB,
patch
|
benjamin
:
review-
|
Details | Diff | Splinter Review |
Error: no element found
Source File: jar:resource:///chrome/en-US.jar!/locale/en-US/reporter/contents.rdf
Line: 1
Error: undefined entity
Source File: chrome://reporter/content/reporterOverlay.xul
Line: 50, Column: 5
Source Code:
<menuitem id="menu_HelpPopup_reportertoolmenu"
installer needs to registerChrome properly
| Assignee | ||
Comment 1•21 years ago
|
||
Attachment #190255 -
Flags: review?(benjamin)
Attachment #190255 -
Flags: approval1.8b4?
Comment 2•21 years ago
|
||
Comment on attachment 190255 [details] [diff] [review]
patch (checked in)
Do you want to register all the non-English locales also, or not bother?
Attachment #190255 -
Flags: review?(benjamin)
Attachment #190255 -
Flags: review+
Attachment #190255 -
Flags: approval1.8b4?
Attachment #190255 -
Flags: approval1.8b4+
| Assignee | ||
Comment 3•21 years ago
|
||
Attachment #190255 -
Attachment is obsolete: true
| Assignee | ||
Updated•21 years ago
|
Attachment #190266 -
Flags: review?(benjamin)
Attachment #190266 -
Flags: approval1.8b4?
Comment on attachment 190255 [details] [diff] [review]
patch (checked in)
Checked in. The second patch is probably bitrotted as a result.
Attachment #190255 -
Attachment description: patch → patch (checked in)
Attachment #190255 -
Attachment is obsolete: false
Comment 5•21 years ago
|
||
Comment on attachment 190266 [details] [diff] [review]
one patch to register them all
I don't think we want to do this without makefile-magic , since the list of all
locales may change fairly frequently over time.
Attachment #190266 -
Flags: review?(benjamin)
Attachment #190266 -
Flags: review-
Attachment #190266 -
Flags: approval1.8b4?
Comment 6•20 years ago
|
||
The second part is obsolete, as reporter locales other than en-US aren't in the reporter.jar any more, from what I see.
The first part is FIXED though.
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•